<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>+ Anna.</div><br><div><div>On Jun 11, 2013, at 1:30 AM, Pavel Labath <<a href="mailto:labath@google.com">labath@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Hi klimek,<br><br>"register" functions for the checker were caching the checker objects in a<br>static variable. This caused problems when the function is called with a<br>different CheckerManager.<br><br><a href="http://llvm-reviews.chandlerc.com/D955">http://llvm-reviews.chandlerc.com/D955</a><br><br>Files:<br> lib/StaticAnalyzer/Checkers/CStringChecker.cpp<br><br>Index: lib/StaticAnalyzer/Checkers/CStringChecker.cpp<br>===================================================================<br>--- lib/StaticAnalyzer/Checkers/CStringChecker.cpp<br>+++ lib/StaticAnalyzer/Checkers/CStringChecker.cpp<br>@@ -2018,10 +2018,7 @@<br><br>#define REGISTER_CHECKER(name) \<br>void ento::register##name(CheckerManager &mgr) {\<br>- static CStringChecker *TheChecker = 0; \<br>- if (TheChecker == 0) \<br>- TheChecker = mgr.registerChecker<CStringChecker>(); \<br>- TheChecker->Filter.Check##name = true; \<br>+ mgr.registerChecker<CStringChecker>()->Filter.Check##name = true; \<br>}<br><br>REGISTER_CHECKER(CStringNullArg)<br><span><Mail Attachment></span>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></div></blockquote></div><br></body></html>