<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Jun 10, 2013, at 17:12 , Arthur O'Dwyer <<a href="mailto:arthur.j.odwyer@gmail.com">arthur.j.odwyer@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Mon, Jun 10, 2013 at 4:51 PM, Fariborz Jahanian <<a href="mailto:fjahanian@apple.com">fjahanian@apple.com</a>> wrote:<br><blockquote type="cite"><br>+def warn_missing_atsign_prefix : Warning<<br>+ "string literal must be prefixed by '@' ">, InGroup<ObjCLiteralMissingAtSign>;<br></blockquote><br>Shouldn't this say "NSString literal", not "string literal"?<br>Objective-C has the same<br>string literals as C and C++, and they don't need to be prefixed by<br>'@'. I feel like<br>overriding the term "string literal" in this message to refer<br>specifically to NSString<br>literals is actually more confusing than it is helpful.<br></div></blockquote><div dir="auto"><br></div><div dir="auto">I thought about this in looking at the patch, but it doesn't match with similar diagnostics about "array literals" and "dictionary literals". Moreover, it's not actually guaranteed that the constant string class is called "NSString".</div><div dir="auto"><br></div><div dir="auto">If we wanted this, we could either look up the string class name, or refer to "Objective-C string literal".</div><div dir="auto"><br></div><div dir="auto">Jordan</div></div></body></html>