<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Jun 3, 2013, at 2:14 PM, Edwin Vane <<a href="mailto:edwin.vane@intel.com">edwin.vane@intel.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Author: revane<br>Date: Mon Jun 3 16:14:24 2013<br>New Revision: 183154<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=183154&view=rev">http://llvm.org/viewvc/llvm-project?rev=183154&view=rev</a><br>Log:<br>cpp11-migrate: turn off PID-based perf data filenames<br><br>Getting PIDs on Windows is broken. Proper fix is simple but requires testing so<br>just disabling PID-based file names for now.<br></div></blockquote><div><br></div>Thanks for quick respond. Windows build is happy once again.</div><div><br></div><div>- Fariborz</div><div><br><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br><br>Modified:<br> clang-tools-extra/trunk/cpp11-migrate/tool/Cpp11Migrate.cpp<br><br>Modified: clang-tools-extra/trunk/cpp11-migrate/tool/Cpp11Migrate.cpp<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/cpp11-migrate/tool/Cpp11Migrate.cpp?rev=183154&r1=183153&r2=183154&view=diff">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/cpp11-migrate/tool/Cpp11Migrate.cpp?rev=183154&r1=183153&r2=183154&view=diff</a><br>==============================================================================<br>--- clang-tools-extra/trunk/cpp11-migrate/tool/Cpp11Migrate.cpp (original)<br>+++ clang-tools-extra/trunk/cpp11-migrate/tool/Cpp11Migrate.cpp Mon Jun 3 16:14:24 2013<br>@@ -103,8 +103,12 @@ void reportExecutionTimes(<br> P.createDirectoryOnDisk(true);<br><br> // Get PID and current time.<br>- llvm::sys::self_process *SP = llvm::sys::process::get_self();<br>- unsigned Pid = SP->get_id();<br>+ // FIXME: id_type on Windows is NOT a process id despite the function name.<br>+ // Need to call GetProcessId() providing it what get_id() returns. For now<br>+ // disabling PID-based file names until this is fixed properly.<br>+ //llvm::sys::self_process *SP = llvm::sys::process::get_self();<br>+ //id_type Pid = SP->get_id();<br>+ unsigned Pid = 0;<br> llvm::TimeRecord T = llvm::TimeRecord::getCurrentTime();<br><br> std::string FileName;<br><br><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></div></blockquote></div><br></body></html>