On Thu, May 23, 2013 at 3:03 PM, Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div>Eek. This would have been caught by -Wshadow, right? Can we rename the local Dest to something else?</div></div></blockquote><div><br></div><div>Seems like a good idea, although I'm not sure it entirely removes the risk.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><span class="HOEnZb"><font color="#888888"><div>Jordan</div></font></span><div>
<div class="h5"><div><br></div><br><div><div>On May 23, 2013, at 14:54 , Richard Smith <<a href="mailto:richard-llvm@metafoo.co.uk" target="_blank">richard-llvm@metafoo.co.uk</a>> wrote:</div><br><blockquote type="cite">
<div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">Author: rsmith<br>Date: Thu May 23 16:54:14 2013<br>New Revision: 182615<br><br>URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project?rev=182615&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=182615&view=rev</a><br>
Log:<br>Fix assert on temporary std::initializer_list.<br><br>Modified:<br>   cfe/trunk/lib/CodeGen/CGExprAgg.cpp<br>   cfe/trunk/test/CodeGenCXX/cxx0x-initializer-stdinitializerlist.cpp<br><br>Modified: cfe/trunk/lib/CodeGen/CGExprAgg.cpp<br>
URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprAgg.cpp?rev=182615&r1=182614&r2=182615&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprAgg.cpp?rev=182615&r1=182614&r2=182615&view=diff</a><br>
==============================================================================<br>--- cfe/trunk/lib/CodeGen/CGExprAgg.cpp (original)<br>+++ cfe/trunk/lib/CodeGen/CGExprAgg.cpp Thu May 23 16:54:14 2013<br>@@ -1159,12 +1159,13 @@ void AggExprEmitter::VisitInitListExpr(I<br>
  if (E->hadArrayRangeDesignator())<br>    CGF.ErrorUnsupported(E, "GNU array range designator extension");<br><br>+  AggValueSlot Dest = EnsureSlot(E->getType());<br>+<br>  if (E->initializesStdInitializerList()) {<br>
    EmitStdInitializerList(Dest.getAddr(), E);<br>    return;<br>  }<br><br>-  AggValueSlot Dest = EnsureSlot(E->getType());<br>  LValue DestLV = CGF.MakeAddrLValue(Dest.getAddr(), E->getType(),<br>                                     Dest.getAlignment());<br>
<br><br>Modified: cfe/trunk/test/CodeGenCXX/cxx0x-initializer-stdinitializerlist.cpp<br>URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/cxx0x-initializer-stdinitializerlist.cpp?rev=182615&r1=182614&r2=182615&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/cxx0x-initializer-stdinitializerlist.cpp?rev=182615&r1=182614&r2=182615&view=diff</a><br>
==============================================================================<br>--- cfe/trunk/test/CodeGenCXX/cxx0x-initializer-stdinitializerlist.cpp (original)<br>+++ cfe/trunk/test/CodeGenCXX/cxx0x-initializer-stdinitializerlist.cpp Thu May 23 16:54:14 2013<br>
@@ -275,3 +275,13 @@ namespace rdar13325066 {<br>    for (X x : { x1, x2 }) { }<br>  }<br>}<br>+<br>+namespace dtors {<br>+  struct S {<br>+    S();<br>+    ~S();<br>+  };<br>+  void f() {<br>+    std::initializer_list<S>{ S(), S() };<br>
+  }<br>+}<br><br><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></div>
</blockquote></div><br></div></div></div></blockquote></div><br>