<div dir="ltr">On Mon, May 20, 2013 at 3:18 PM, Alexander Kornienko <span dir="ltr"><<a href="mailto:alexfh@google.com" target="_blank">alexfh@google.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: alexfh<br>
Date: Mon May 20 10:18:01 2013<br>
New Revision: 182290<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=182290&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=182290&view=rev</a><br>
Log:<br>
Minor fix: don't crash on empty configuration file, consider empty configuration files invalid.<br></blockquote><div><br></div><div style>Test case please!</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
cfe/trunk/lib/Format/Format.cpp<br>
<br>
Modified: cfe/trunk/lib/Format/Format.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/Format.cpp?rev=182290&r1=182289&r2=182290&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/Format.cpp?rev=182290&r1=182289&r2=182290&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Format/Format.cpp (original)<br>
+++ cfe/trunk/lib/Format/Format.cpp Mon May 20 10:18:01 2013<br>
@@ -201,6 +201,8 @@ bool getPredefinedStyle(StringRef Name,<br>
}<br>
<br>
llvm::error_code parseConfiguration(StringRef Text, FormatStyle *Style) {<br>
+ if (Text.trim().empty())<br>
+ return llvm::make_error_code(llvm::errc::invalid_argument);<br>
llvm::yaml::Input Input(Text);<br>
Input >> *Style;<br>
return Input.error();<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>