<div dir="ltr">Hi Bill,<div><br></div><div style>This is a correction of the first patch. Also, please consider merging to 3.3.</div><div style><br></div><div style>Thanks,</div><div style>--renato</div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On 14 May 2013 01:44, Rafael Espindola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: rafael<br>
Date: Mon May 13 19:44:24 2013<br>
New Revision: 181750<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=181750&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=181750&view=rev</a><br>
Log:<br>
Use atomic instructions on linux thumb v7.<br>
<br>
This matches gcc's behaviour. The patch also explicitly parses the version so<br>
that this keeps working when we add support for v8.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Basic/Targets.cpp<br>
    cfe/trunk/test/CodeGen/linux-arm-atomic.c<br>
<br>
Modified: cfe/trunk/lib/Basic/Targets.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=181750&r1=181749&r2=181750&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=181750&r1=181749&r2=181750&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/Basic/Targets.cpp (original)<br>
+++ cfe/trunk/lib/Basic/Targets.cpp Mon May 13 19:44:24 2013<br>
@@ -3536,9 +3536,23 @@ class ARMTargetInfo : public TargetInfo<br>
     if (T.getOS() != llvm::Triple::Linux)<br>
      return false;<br>
     StringRef ArchName = T.getArchName();<br>
-    if (ArchName.startswith("armv6") || ArchName.startswith("armv7"))<br>
-      return true;<br>
-    return false;<br>
+    if (T.getArch() == llvm::Triple::arm) {<br>
+      if (!ArchName.startswith("armv"))<br>
+        return false;<br>
+      StringRef VersionStr = ArchName.substr(4);<br>
+      unsigned Version;<br>
+      if (VersionStr.getAsInteger(10, Version))<br>
+        return false;<br>
+      return Version >= 6;<br>
+    }<br>
+    assert(T.getArch() == llvm::Triple::thumb);<br>
+    if (!ArchName.startswith("thumbv"))<br>
+      return false;<br>
+    StringRef VersionStr = ArchName.substr(6);<br>
+    unsigned Version;<br>
+    if (VersionStr.getAsInteger(10, Version))<br>
+      return false;<br>
+    return Version >= 7;<br>
   }<br>
<br>
 public:<br>
<br>
Modified: cfe/trunk/test/CodeGen/linux-arm-atomic.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/linux-arm-atomic.c?rev=181750&r1=181749&r2=181750&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/linux-arm-atomic.c?rev=181750&r1=181749&r2=181750&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/test/CodeGen/linux-arm-atomic.c (original)<br>
+++ cfe/trunk/test/CodeGen/linux-arm-atomic.c Mon May 13 19:44:24 2013<br>
@@ -1,5 +1,6 @@<br>
 // RUN: %clang_cc1 %s -emit-llvm -o - -triple=armv7-unknown-linux | FileCheck %s<br>
 // RUN: %clang_cc1 %s -emit-llvm -o - -triple=armv6-unknown-linux | FileCheck %s<br>
+// RUN: %clang_cc1 %s -emit-llvm -o - -triple=thumbv7-unknown-linux | FileCheck %s<br>
<br>
 typedef int _Atomic_word;<br>
 _Atomic_word exchange_and_add(volatile _Atomic_word *__mem, int __val) {<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>