<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>LGTM <br><br>Sent from my iPhone</div><div><br>On May 10, 2013, at 3:51 AM, Faisal Vali <<a href="mailto:faisalv@gmail.com">faisalv@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr"><div>As per Chandler's suggestion to separate out the bug fix from the refactoring - see comment below regarding this bug fix patch.<br><br></div>Thank you!<br><div><div><div class="gmail_extra"><br clear="all">
<div>Faisal Vali<br><br></div>
<br><br><div class="gmail_quote">On Thu, May 9, 2013 at 11:36 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="im"><br><div class="gmail_quote">On Fri, May 10, 2013 at 6:14 AM, Faisal Vali <span dir="ltr"><<a href="mailto:faisalv@gmail.com" target="_blank">faisalv@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>As I was working on captures within Generic Lambdas, I thought it would be nice to refactor the very long function : tryCaptureVariable. Please let me know if you think this refactoring is useful and if you have any suggestions for improving the refactoring.<br>
<br></div>Also, I fixed a bug in my initial TemplateParameterDepth patch - the Depth counter was getting incremented when it shouldn't have (that is for a non-class template) in delayed-template parsing mode. I included a test that previously asserted, and now compiles and behaves as it should.</blockquote>
</div><br></div>In general I think it would be very good to separate out these two patches (and similarly separable patches). I think getting the bug fix reviewed and in should be done independently of refactoring which doesn't change functionality.</div>
</div>
</blockquote></div><br></div></div></div></div>
</div></blockquote><blockquote type="cite"><div><template-parameter-depth-fix-dont-increment-if-not-classtemplate.patch></div></blockquote></body></html>