<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On May 7, 2013, at 10:17 AM, Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Tue, May 7, 2013 at 10:04 AM, Vane, Edwin<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:edwin.vane@intel.com" target="_blank">edwin.vane@intel.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">Probably a good idea. Who has to do that?</blockquote><div><br></div><div>Please add a test case, then ask the code owner to approve for the branch (and CC the release manager).</div><div><br></div><div>The code owner for ASTMatchers should probably be Manuel but appears to currently be Doug. The release manager is Bill Wendling.</div></div></div></blockquote><div><br></div><div>The commit is fine to pull into the 3.3 branch with a test.</div><div><br></div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div><div><br><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">> -----Original Message-----<br>> From: Dmitri Gribenko [mailto:<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>]<br>> Sent: Tuesday, May 07, 2013 11:57 AM<br>> To: Vane, Edwin<br>> Cc: cfe-commits cfe<br>> Subject: Re: r181329 - Prevent crashes from hasCanonicalType matcher<br>><br>> On Tue, May 7, 2013 at 6:53 PM, Edwin Vane <<a href="mailto:edwin.vane@intel.com" target="_blank">edwin.vane@intel.com</a>> wrote:<br>> > Author: revane<br>> > Date: Tue May 7 10:53:23 2013<br>> > New Revision: 181329<br>> ><br>> > URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=181329&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=181329&view=rev</a><br>> > Log:<br>> > Prevent crashes from hasCanonicalType matcher<br>> ><br>> > Adding an QualType::isNull() check.<br>><br>> Shall we commit this to Clang 3.3 branch, too?<br>><br>> Dmitri<br>><br>> --<br>> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if<br>> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>>*/<br><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></blockquote></div></div></blockquote></div><br></body></html>