<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On May 7, 2013, at 1:20 PM, Nico Weber <<a href="mailto:thakis@chromium.org">thakis@chromium.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr">Thanks for the review!<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, May 7, 2013 at 1:12 PM, jahanian<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:fjahanian@apple.com" target="_blank">fjahanian@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;">Patch is OK. But I am concerned about producing ABI incompatibility with older clangs.</div></blockquote><div><br></div><div>That's a valid concern. It _does_ restore ABI compatibility with gcc; some code in Chromium apparently relied on the original behavior.</div><div><br></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;">Also, similar problem exists<div>with the ‘copy’ attribute (and probably others I haven’t tried).</div></div></blockquote><div><br></div><div>'copy' and 'retain' can't be used together as far as I know.<br></div></div></div></div></div></blockquote><div><br></div>Sorry for not being clear. I meant when attribute is ‘copy’ (instead of ‘retain’).</div><div><br></div><div>- Fariborz</div><div><br><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;">Let me run this by our runtime guys to see its impact.</div></blockquote><div><br></div><div>Thanks!</div><div> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;"><div><br></div><div>- Fariborz</div><div><br><div><div><div class="h5"><div>On May 7, 2013, at 12:25 PM, Nico Weber <<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>> wrote:</div><br></div></div><blockquote type="cite"><div style="letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;"><div><div class="h5"><div dir="ltr">Hi,<div><br></div><div>clang omits the '&' for retained properties if the property is also readonly. The attached patch fixes this – it makes clang match gcc's behavior and fixes PR15928.</div><div><br></div><div>Ok?</div><div><br></div><div>Nico</div></div></div></div><span><clang-retain.patch></span>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></div></blockquote></div><br></div></div></blockquote></div><br></div></div></div><br class="Apple-interchange-newline"></blockquote></div><br></body></html>