<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div></div><div><br></div><div><br><div><div>On May 1, 2013, at 10:04 AM, Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Hi!<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, May 1, 2013 at 9:29 AM, Joe Sprowes <span dir="ltr"><<a href="mailto:sprowes@silkan.com" target="_blank">sprowes@silkan.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><div class="h5">Hi,<br><font color="#0f61c8"><br></font>I am new to clang and want to get involved. Hopefully, someone will walk me through the process.<br>
<font color="#0f61c8"><br></font>I found that atomic expressions were printed with an extra comma following the argument list:<br><font color="#0f61c8"><br></font>For example:<br><font color="#0f61c8"><br></font>__c11_atomic_init(&i, 0);<br>
<font color="#0f61c8"><br></font>is printed as:<br><font color="#0f61c8"><br></font>__c11_atomic_init(&i, 0, );<br><font color="#0f61c8"><br></font></div></div>Attached is a patch to fix this. I attached a test.</div>
</div></blockquote><div><br></div><div style="">Patch and test both look good. We try to minimize the number of distinct test files (this makes a difference to the efficiency of running the tests in some contexts) so please merge this into an appropriate existing test for -ast-print ("grep -r ast-print test/" to find them).</div>
<div style=""><br></div><div style="">Also, as a procedural issue, please provide a single patch covering both code changes and test changes. We prefer patches which can be applied with patch -p0 (svn diff will create such patches by default, git diff needs a little configuring).</div>
<div style=""><br></div><div style="">Once that's done, send the patch and I'll commit it for you.</div><div style=""><br></div><div style="">Thank you!</div></div></div></div>
</blockquote></div><br></div></body></html>