<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Thanks, Ben.<div><br><div><div>On Apr 27, 2013, at 1:12 AM, Benjamin Kramer <<a href="mailto:benny.kra@googlemail.com">benny.kra@googlemail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Author: d0k<br>Date: Sat Apr 27 03:12:29 2013<br>New Revision: 180669<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=180669&view=rev">http://llvm.org/viewvc/llvm-project?rev=180669&view=rev</a><br>Log:<br>Use LLVM's preferred current_path API instead of calling getcwd(3) directly.<br><br>The existing code also failed to allocate a buffer for it so getcwd corrupted<br>the stack. sys::fs::current_path takes care of the memory management.<br><br>Modified:<br> cfe/trunk/lib/Driver/Tools.cpp<br><br>Modified: cfe/trunk/lib/Driver/Tools.cpp<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=180669&r1=180668&r2=180669&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=180669&r1=180668&r2=180669&view=diff</a><br>==============================================================================<br>--- cfe/trunk/lib/Driver/Tools.cpp (original)<br>+++ cfe/trunk/lib/Driver/Tools.cpp Sat Apr 27 03:12:29 2013<br>@@ -1775,9 +1775,6 @@ static bool shouldUseLeafFramePointer(co<br> return true;<br>}<br><br>-// FIXME: This is a temporary hack until I can find a fix that works for all<br>-// platforms.<br>-#define MAXPATHLEN 4096<br>/// If the PWD environment variable is set, add a CC1 option to specify the<br>/// debug compilation directory.<br>static void addDebugCompDirArg(const ArgList &Args, ArgStringList &CmdArgs) {<br>@@ -1794,9 +1791,10 @@ static void addDebugCompDirArg(const Arg<br> CmdArgs.push_back(Args.MakeArgString(pwd));<br> return;<br> }<br>+<br> // Fall back to using getcwd.<br>- char *cwd;<br>- if (pwd && ::getcwd(cwd, MAXPATHLEN)) {<br>+ SmallString<128> cwd;<br>+ if (!llvm::sys::fs::current_path(cwd)) {<br> CmdArgs.push_back("-fdebug-compilation-dir");<br> CmdArgs.push_back(Args.MakeArgString(cwd));<br> }<br><br><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></div></blockquote></div><br></div></body></html>