<div dir="ltr"><div style>Hi Richard,</div><div style><br></div><div style>Thanks for the review!</div><div><br></div><br><div class="gmail_extra"><div class="gmail_quote">On 26 April 2013 17:23, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Change LGTM, thanks.</div><div><br></div><div>+ if (ClassTemplatePartialSpecializationDecl* MD =</div>
<div>+ dyn_cast_or_null<ClassTemplatePartialSpecializationDecl>(*II)) {</div>
<div>+ TemplateParamScopeStack.push_back(new ParseScope(this,</div><div>+ Scope::TemplateParamScope));</div><div>+ Actions.ActOnReenterTemplateScope(getCurScope(), MD);</div>
<div>+ } else if (CXXRecordDecl* MD = dyn_cast_or_null<CXXRecordDecl>(*II)) {</div><div>+ TemplateParamScopeStack.push_back(new ParseScope(this,</div><div>+ Scope::TemplateParamScope,</div>
<div>+ MD->getDescribedClassTemplate() != 0 ));</div><div><br></div><div>Can you fix the formatting of this code too? :) There's some strange indentation here (probably due to 80-column limits) and an extra space after the 0. Also a typo "outmost" should be "outermost".</div>
</div></blockquote><div><br></div><div style>I've attempted to fix the indenting but I've had to break out an argument in the process, either way I don't think it hinders clarity. Incidentally "outmost" is valid if archaic, but I've changed it anyhow.</div>
<div style><br></div><div style>Let me know if there's anything else, otherwise - over to you!</div></div><br>
</div><div class="gmail_extra" style>- Will.</div><div class="gmail_extra"><br></div></div>