<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Apr 26, 2013, at 6:16 PM, Jordan Rose <<a href="mailto:jordan_rose@apple.com">jordan_rose@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Actually, this should probably get off PathV1.h altogether, and just use llvm::sys::fs::current_path in FileSystem.h.</div><div><br></div><div>Sorry for asking you to change this<span class="Apple-converted-space"> </span><i>again…</i></div></div></blockquote><div><br></div><div>No worries, thanks for the suggestion. I put in a temporary fix to appease the bots and gdb tests. I'll give your suggestion a try once I am able to continue watching the bots. For now I need to get out of the office.</div><div><br></div><div>Thanks, Jordan.</div><br><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Apr 26, 2013, at 17:57 , Chad Rosier <<a href="mailto:mcrosier@apple.com">mcrosier@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Author: mcrosier<br>Date: Fri Apr 26 19:57:18 2013<br>New Revision: 180658<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=180658&view=rev">http://llvm.org/viewvc/llvm-project?rev=180658&view=rev</a><br>Log:<br>Fix the dangling pointer.<br><br>Modified:<br> cfe/trunk/lib/Driver/Tools.cpp<br><br>Modified: cfe/trunk/lib/Driver/Tools.cpp<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=180658&r1=180657&r2=180658&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=180658&r1=180657&r2=180658&view=diff</a><br>==============================================================================<br>--- cfe/trunk/lib/Driver/Tools.cpp (original)<br>+++ cfe/trunk/lib/Driver/Tools.cpp Fri Apr 26 19:57:18 2013<br>@@ -1792,8 +1792,8 @@ static void addDebugCompDirArg(const Arg<br> return;<br> }<br> // Fall back to using getcwd.<br>- const char *cwd = llvm::sys::Path::GetCurrentDirectory().c_str();<br>- if (pwd && cwd) {<br>+ std::string cwd = llvm::sys::Path::GetCurrentDirectory().str();<br>+ if (pwd && !cwd.empty()) {<br> CmdArgs.push_back("-fdebug-compilation-dir");<br> CmdArgs.push_back(Args.MakeArgString(cwd));<br> }<br><br><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></blockquote></div></div></blockquote></div><br></body></html>