<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Apr 26, 2013, at 3:06 PM, Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com">gribozavr@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Fri, Apr 26, 2013 at 11:55 PM, Fariborz Jahanian <<a href="mailto:fjahanian@apple.com">fjahanian@apple.com</a>> wrote:<br><blockquote type="cite">Added: cfe/trunk/test/Misc/ast-dump-subclass-comment.mm<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Misc/ast-dump-subclass-comment.mm?rev=180629&view=auto">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Misc/ast-dump-subclass-comment.mm?rev=180629&view=auto</a><br>==============================================================================<br>--- cfe/trunk/test/Misc/ast-dump-subclass-comment.mm (added)<br>+++ cfe/trunk/test/Misc/ast-dump-subclass-comment.mm Fri Apr 26 15:55:38 2013<br>@@ -0,0 +1,101 @@<br>+// RUN: %clang_cc1 -x objective-c++ -Wdocumentation -ast-dump %s | FileCheck %s<br>+//<span class="Apple-converted-space"> </span><a href="rdar://13647476">rdar://13647476</a><br>+<br>+//! NSObject is root of all.<br>+@interface NSObject<br>+@end<br>+// CHECK: ObjCInterfaceDecl{{.*}}NSObject<br>+// CHECK-NEXT: FullComment 0x{{[^ ]*}} <line:[[@LINE-4]]:4, col:28><br>+// CHECK-NEXT: ParagraphComment{{.*}} <col:4, col:28><br>+// CHECK-NEXT: TextComment{{.*}} <col:4, col:28> Text=" NSObject is root of all."<br></blockquote><br>Hi Fariborz,<br><br>Why does this test use -ast-dump? Usually c-index-test is used to<br>test if comment is attached to something. There are fewer CHECK lines<br>that way.<br></div></blockquote><div><br></div>OK. I will add a c-index test (without removing the existing one which took quite time</div><div>to get it right :).</div><div><br><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>Also, about the approach this patch implements -- while it makes sense<br>in some cases, it can be confusing in most other situations. For<br>example:<br><br>/// A window.<br>class Window {};<br>class Door {};<br><br>class House : Window, Door {};<br><br>'House' will pick up the 'Window' comment, which is probably not what<br>the user wants.<br></div></blockquote><div><br></div>You are right. There are cases which will not make sense. But, not knowing that, we pick the first</div><div>one we see (which meets our user requirements). Generally, Important classes must have their own </div><div>comments.</div><div><br></div><div>- Fariborz</div><div><br><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>Dmitri<br><br>--<br>main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if<br>(j){printf("%d\n",i);}}} /*Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com">gribozavr@gmail.com</a>>*/</div></blockquote></div><br></body></html>