<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">That said… the behavior of this function is currently weird. Returning zero for success some of the times is not great. After further consideration, we should just apply the fix.<div><br></div><div>Patch applied in r180177.</div><div><br></div><div>Thanks for following up on this.<br><div><div><br><div><div>On Apr 24, 2013, at 12:20 AM, Ted Kremenek <<a href="mailto:kremenek@apple.com">kremenek@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=us-ascii"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">The comments in the PR were to keep the function, so I won't rip it out.<div><br></div><div>That said, if there are clients, I'd prefer we change the documentation, not the behavior of the code itself.</div><div><br><div><div>On Apr 23, 2013, at 11:48 PM, Ted Kremenek <<a href="mailto:kremenek@apple.com">kremenek@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=us-ascii"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Thanks Nikola. This PR and patch made me go back and re-evaluate the purpose and need for this function. I don't think there are any clients of CXCursorSet, so I think I will just remove it entirely.<div><br></div><div>Thanks for investigating this.<br><div><br><div><div>On Apr 22, 2013, at 2:12 AM, Nikola Smiljanic <<a href="mailto:popizdeh@gmail.com">popizdeh@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">I was going through bugizilla when I ran into this one <a href="http://llvm.org/bugs/show_bug.cgi?id=10124">http://llvm.org/bugs/show_bug.cgi?id=10124</a> Bug and patch look good but I wanted to double check if this is OK to commit and close?<div>
<br></div><div>CCing Ted since he seems to be the author of the function.</div>
</div>
</blockquote></div><br></div></div></div>
_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br></blockquote></div><br></div></div>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits<br></blockquote></div><br></div></div></div></body></html>