<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>No, that's not correct either. Microsoft's #pragma message <i>requires</i> parens, while #pragma GCC (error|warning) apparently requires <i>no</i> parens. (GCC's #pragma message seems to be MS-inspired, as it has no GCC namespace and optionally allows parens.)</div><div><br></div><div><a href="http://msdn.microsoft.com/en-us/library/x7dkzch2(v=vs.80).aspx">http://msdn.microsoft.com/en-us/library/x7dkzch2(v=vs.80).aspx</a></div><div><a href="http://gcc.gnu.org/onlinedocs/cpp/Pragmas.html">http://gcc.gnu.org/onlinedocs/cpp/Pragmas.html</a></div><div><a href="http://gcc.gnu.org/onlinedocs/gcc/Diagnostic-Pragmas.html">http://gcc.gnu.org/onlinedocs/gcc/Diagnostic-Pragmas.html</a></div><div><br></div><div>I'm okay with not really striving for source fidelity here; since there's no #pragma GCC message, it's probably safe to just parenthesize message all the time.</div><div>Jordan</div><div><br></div><br><div><div>On Apr 18, 2013, at 9:49 , Andy Gibbs <<a href="mailto:andyg1001@hotmail.co.uk">andyg1001@hotmail.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Author: andyg<br>Date: Thu Apr 18 11:49:37 2013<br>New Revision: 179771<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=179771&view=rev">http://llvm.org/viewvc/llvm-project?rev=179771&view=rev</a><br>Log:<br>Dropped the parentheses for #pragma message and its kin in the -E output generator.<br><br>This was a suggestion by Jordan Rose since the documented format for these pragmas is without the parentheses. At the same time, I've increased test coverage too for the preprocessed output.<br><br>Added:<br> cfe/trunk/test/Lexer/pragma-message2.c<br>Modified:<br> cfe/trunk/lib/Frontend/PrintPreprocessedOutput.cpp<br> cfe/trunk/test/Lexer/pragma-operators.cpp<br><br>Modified: cfe/trunk/lib/Frontend/PrintPreprocessedOutput.cpp<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/PrintPreprocessedOutput.cpp?rev=179771&r1=179770&r2=179771&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/PrintPreprocessedOutput.cpp?rev=179771&r1=179770&r2=179771&view=diff</a><br>==============================================================================<br>--- cfe/trunk/lib/Frontend/PrintPreprocessedOutput.cpp (original)<br>+++ cfe/trunk/lib/Frontend/PrintPreprocessedOutput.cpp Thu Apr 18 11:49:37 2013<br>@@ -419,13 +419,13 @@ void PrintPPOutputPPCallbacks::PragmaMes<br> OS << Namespace << ' ';<br> switch (Kind) {<br> case PMK_Message:<br>- OS << "message(\"";<br>+ OS << "message \"";<br> break;<br> case PMK_Warning:<br>- OS << "warning(\"";<br>+ OS << "warning \"";<br> break;<br> case PMK_Error:<br>- OS << "error(\"";<br>+ OS << "error \"";<br> break;<br> }<br><br>@@ -440,8 +440,6 @@ void PrintPPOutputPPCallbacks::PragmaMes<br> << (char)('0'+ ((Char >> 0) & 7));<br> }<br> OS << '"';<br>-<br>- OS << ')';<br> setEmittedDirectiveOnThisLine();<br>}<br><br><br>Added: cfe/trunk/test/Lexer/pragma-message2.c<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Lexer/pragma-message2.c?rev=179771&view=auto">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Lexer/pragma-message2.c?rev=179771&view=auto</a><br>==============================================================================<br>--- cfe/trunk/test/Lexer/pragma-message2.c (added)<br>+++ cfe/trunk/test/Lexer/pragma-message2.c Thu Apr 18 11:49:37 2013<br>@@ -0,0 +1,19 @@<br>+// RUN: %clang_cc1 -E -Werror -verify %s 2>&1 | FileCheck %s<br>+<br>+#pragma message "<a href="smb://test">\\test</a>" // expected-warning {{\test}}<br>+// CHECK: #pragma message "\134test"<br>+<br>+#pragma message("\\test") // expected-warning {{\test}}<br>+// CHECK: #pragma message "\134test"<br>+<br>+#pragma GCC warning "\"" "te" "st" "\"" // expected-warning {{"test"}}<br>+// CHECK: #pragma GCC warning "\042test\042"<br>+<br>+#pragma GCC warning("\"" "te" "st" "\"") // expected-warning {{"test"}}<br>+// CHECK: #pragma GCC warning "\042test\042"<br>+<br>+#pragma GCC error "" "[<span class="Apple-tab-span" style="white-space: pre;"> </span>]" "" // expected-error {{[<span class="Apple-tab-span" style="white-space: pre;"> </span>]}}<br>+// CHECK: #pragma GCC error "[\011]"<br>+<br>+#pragma GCC error("" "[<span class="Apple-tab-span" style="white-space: pre;"> </span>]" "") // expected-error {{[<span class="Apple-tab-span" style="white-space: pre;"> </span>]}}<br>+// CHECK: #pragma GCC error "[\011]"<br><br>Modified: cfe/trunk/test/Lexer/pragma-operators.cpp<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Lexer/pragma-operators.cpp?rev=179771&r1=179770&r2=179771&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Lexer/pragma-operators.cpp?rev=179771&r1=179770&r2=179771&view=diff</a><br>==============================================================================<br>--- cfe/trunk/test/Lexer/pragma-operators.cpp (original)<br>+++ cfe/trunk/test/Lexer/pragma-operators.cpp Thu Apr 18 11:49:37 2013<br>@@ -32,6 +32,6 @@ B(foo)<br>// CHECK: #pragma comment(lib, "libfoo")<br>// CHECK: #pragma clang diagnostic ignored "-Wunused"<br>// CHECK: #pragma clang diagnostic error "-Wunused"<br>-// CHECK: #pragma message("\042Hello\042, world!")<br>+// CHECK: #pragma message "\042Hello\042, world!"<br>// CHECK: 0;<br>int n = pragma_L pragma_u8 pragma_u pragma_U pragma_R pragma_UR pragma_hello 0;<br><br><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></div></blockquote></div><br></body></html>