<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Committed as r179680, thanks! Please go ahead and close the PR.<div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div><div><br><div><div>On Apr 16, 2013, at 8:46 PM, Alexander Zinenko <<a href="mailto:ftynse@gmail.com">ftynse@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Hello Doug!<div><br></div><div>Thanks for the review!</div><div>Everything mentioned is fixed. Please find the updated patch attached.</div><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">
On 16 April 2013 19:41, Douglas Gregor <span dir="ltr"><<a href="mailto:dgregor@apple.com" target="_blank">dgregor@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><br><div><div class="im"><div>On Mar 7, 2013, at 8:39 PM, Alexander Zinenko <<a href="mailto:ftynse@gmail.com" target="_blank">ftynse@gmail.com</a>> wrote:</div><br><blockquote type="cite">
<div dir="ltr">Ping?</div></blockquote><div><br></div></div><div>+bool Sema::SameTypesOrCompatibleFunctions(QualType Param,</div><div>+ QualType Arg) {</div><div><br></div><div>We're starting function names with a lowercase letter now. How about calling this isSameOrCompatibleFunctionType?</div>
<div><br></div><div><div>+ if (!ParamFunction || !ArgFunction)</div><div>+ return Param == Arg;</div><div><br></div><div>Please change the parameters to CanQualTypes, because these == operations only work because we know we're getting canonical types, and that's not clear from the interface.</div>
<div><br></div><div>+ if (IsNoReturnConversion(Param, Arg, AdjustedParam))</div><div>+ return Arg == AdjustedParam;</div><div><br></div><div>You'll probably need to recanonicalize AdjustedParam here.</div>
</div></div></div></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><br></div><div><div>+ // TODO(ftynse): Compatible calling conventions.</div>
<div>+ </div></div><div>Usually we just write "FIXME: what we need to fix"</div><div><br></div><div>Otherwise, this patch looks great!</div><div><br></div><div><span style="white-space:pre-wrap"> </span>- Doug</div>
</div><br></div></blockquote></div><br></div></div>
<span><PR15291.patch></span></blockquote></div><br></div></body></html>