<div dir="ltr">On Tue, Apr 16, 2013 at 3:50 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="im"><p dir="ltr"><br>
On Apr 17, 2013 6:37 AM, "Richard Trieu" <<a href="mailto:rtrieu@google.com" target="_blank">rtrieu@google.com</a>> wrote:<br>
><br>
> On Tue, Apr 16, 2013 at 12:47 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br>
>><br>
>> On Tue, Apr 9, 2013 at 3:06 PM, Richard Trieu <<a href="mailto:rtrieu@google.com" target="_blank">rtrieu@google.com</a>> wrote:<br>
>> > Author: rtrieu<br>
>> > Date: Tue Apr 9 17:06:27 2013<br>
>> > New Revision: 179131<br>
>> ><br>
>> > URL: <a href="http://llvm.org/viewvc/llvm-project?rev=179131&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=179131&view=rev</a><br>
>> > Log:<br>
>> > Remove outdated run lines from tests.<br>
>> ><br>
>> > These run lines originally tested that the fix-its were properly applied.<br>
>> > Originally, the fixits were attached to warnings and were applied by -fixit.<br>
>> > Now, the fixits are attached to notes, so nothing happens. These run lines<br>
>> > still manage to pass since Clang will produce an empty output which gets piped<br>
>> > back to Clang.<br>
>><br>
>> Is that a bug? That seems like a bug.<br>
><br>
><br>
> I'm not sure. I don't think -fixit ever supported -o. </p>
</div><p dir="ltr">Perhaps not explicitly/deliberately, but I assume under some conditions it was producing some kind of valid c++ on stdout, otherwise that lit test would've failed, right? Or perhaps I'm missing something here.</p>
<p dir="ltr">Yeah, I don't understand why this test ever would've passed. The second command should have always failed. -o should set the output of the command which should be the object file, not the modified source...</p>
</blockquote><div style>I didn't see Clang produce any output with -fixit and -o. It passes because the next Clang command is run on an empty input, for which Clang does not produce any errors.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class=""><div class="h5">
<p dir="ltr">>><br>
>><br>
>> > Then Clang produces no error on an empty input.<br>
>> ><br>
>> > Modified:<br>
>> > cfe/trunk/test/Sema/parentheses.c<br>
>> > cfe/trunk/test/Sema/parentheses.cpp<br>
>> ><br>
>> > Modified: cfe/trunk/test/Sema/parentheses.c<br>
>> > URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/parentheses.c?rev=179131&r1=179130&r2=179131&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/parentheses.c?rev=179131&r1=179130&r2=179131&view=diff</a><br>
>> > ==============================================================================<br>
>> > --- cfe/trunk/test/Sema/parentheses.c (original)<br>
>> > +++ cfe/trunk/test/Sema/parentheses.c Tue Apr 9 17:06:27 2013<br>
>> > @@ -1,5 +1,4 @@<br>
>> > // RUN: %clang_cc1 -Wparentheses -fsyntax-only -verify %s<br>
>> > -// RUN: %clang_cc1 -Wparentheses -fixit %s -o - | %clang_cc1 -Wparentheses -Werror -<br>
>> ><br>
>> > // Test the various warnings under -Wparentheses<br>
>> > void if_assign(void) {<br>
>> ><br>
>> > Modified: cfe/trunk/test/Sema/parentheses.cpp<br>
>> > URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/parentheses.cpp?rev=179131&r1=179130&r2=179131&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/parentheses.cpp?rev=179131&r1=179130&r2=179131&view=diff</a><br>
>> > ==============================================================================<br>
>> > --- cfe/trunk/test/Sema/parentheses.cpp (original)<br>
>> > +++ cfe/trunk/test/Sema/parentheses.cpp Tue Apr 9 17:06:27 2013<br>
>> > @@ -1,5 +1,4 @@<br>
>> > // RUN: %clang_cc1 -Wparentheses -fsyntax-only -verify %s<br>
>> > -// RUN: %clang_cc1 -Wparentheses -fixit %s -o - | %clang_cc1 -Wparentheses -Werror -<br>
>> ><br>
>> > bool someConditionFunc();<br>
>> ><br>
>> ><br>
>> ><br>
>> > _______________________________________________<br>
>> > cfe-commits mailing list<br>
>> > <a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
>> > <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
><br>
><br>
</p>
</div></div></blockquote></div><br></div></div>