<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Er.. Ping? <br>
<br>
Or would it be better if by default I submitted to llvm-reviews
first? I just followed the process as laid out in "Hacking Clang".<br>
<br>
Thanks!<br>
<br>
- ½<br>
<br>
On 13-04-10 05:05 PM, Halfdan Ingvarsson wrote:<br>
</div>
<blockquote cite="mid:5165D429.6050201@sidefx.com" type="cite">Hello
<br>
<br>
This is my first patch submission, although I've been using clang
as my primary work compiler for over a year.
<br>
<br>
It's a simple suppression on unused function warnings
(-Wunused-function) for specialized template functions, whose
primary template has a static storage class. E.g:
<br>
<br>
---- 8< ----
<br>
template<typename T> static inline bool
<br>
isNonZero(T a) { return (bool)a; }
<br>
<br>
template<> inline bool
<br>
isNonZero(const char *s) { return s; }
<br>
---- 8< ---
<br>
<br>
Currently the second definition will emit an unused warning.
<br>
<br>
The attached patch uses the storage class from the primary
template when checking whether to omit static inline functions
from the unused warnings (since specializations implicitly inherit
this storage class).
<br>
<br>
- ½
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
cfe-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>