<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 06.04.2013 4:00, Anna Zaks wrote:<br>
</div>
<blockquote
cite="mid:8B1FA7AA-4821-4C8F-B316-7FEA56A79914@apple.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<br>
<div>
<div>On Apr 4, 2013, at 4:46 PM, Anton Yartsev <<a
moz-do-not-send="true" href="mailto:anton.yartsev@gmail.com">anton.yartsev@gmail.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div style="letter-spacing: normal; orphans: auto; text-align:
start; text-indent: 0px; text-transform: none; white-space:
normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px;">+ // Used to suppress
warnings if they are not related to the tracked family<br>
+ // (derived from AllocDeallocStmt).</div>
</blockquote>
<div><br>
</div>
The comment should focus on what the function does not what it's
used for. Also, the name is a bit misleading. isTrackedFamily
sounds like "are we currently tracking this family in the
state?".</div>
<div><br>
</div>
<div>Also, let's try to stick to doxygen comments.</div>
<div><br>
</div>
<div><br>
<blockquote type="cite">
<div style="letter-spacing: normal; orphans: auto; text-align:
start; text-indent: 0px; text-transform: none; white-space:
normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px;">+ bool
isTrackedFamily(AllocationFamily Family) const;<br>
+ bool isTrackedFamily(CheckerContext &C, const Stmt
*AllocDeallocStmt) const;<br>
+ bool isTrackedFamily(CheckerContext &C, SymbolRef
Sym) const;<br>
+<br>
</div>
</blockquote>
</div>
<br>
</blockquote>
Refactored at r179242.<br>
<br>
<pre class="moz-signature" cols="72">--
Anton</pre>
</body>
</html>