<div dir="ltr">I can offer some time for testing locally once this patch is rebased against main.<div><br></div><div style>- Will.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 27 March 2013 01:40, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Sat, Mar 23, 2013 at 4:34 AM, <a href="mailto:endlessroad1991@gmail.com" target="_blank">endlessroad1991@gmail.com</a> <span dir="ltr"><<a href="mailto:endlessroad1991@gmail.com" target="_blank">endlessroad1991@gmail.com</a>></span> wrote:<br>
</div><div class="gmail_quote"><div class="im"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all,<div>Here's an updated version of property patch, based on clang 3.2 release.</div>
<div>Changes:</div><div>- Add tests in Parser and Sema</div><div>- Fix warnings</div><div>- Fix property reference expr serialization/deserialization bug</div>
<div>- Fix property reference of base-class property, like SuperClass::V</div><div><br></div><div>I have been using this patch on a quite large and complex codebase for over a month, including the following situations:</div>
<div>- normal property definition and get/set</div><div>- property reference in almost everywhere: binary-op operand, array-size, function call arguments, var initializer, etc</div><div>- both implicit(this) and explicit property reference</div>
<div>- property whose type is dependent</div><div>- reference of property of super-class</div><div>- headers are compiled into .pch files, and then used by source files(it proves serialization/deserialization works fine)</div>
<div>For now I haven't found any problems.</div><div><br></div><div>I believe it's stable enough.</div><div>So would some clang developer take a final look at this, and try merging it into trunk?</div></blockquote>
<div><br></div></div><div>Please rebase the patch against trunk; clang development moves fast and 3.2 is pretty old now.</div><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>Thank you very much.</div>
<div><div><div><br><div class="gmail_quote">On Fri, Mar 22, 2013 at 8:42 PM, Will Wilson <span dir="ltr"><<a href="mailto:will@indefiant.com" target="_blank">will@indefiant.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Tong Shen et al,<div><br></div><div>What's the current status of this patch? I ask as I'm encountering quite a few examples of MSVC properties in code right now and it's causing something of a headache to workaround. It would be great to see even basic parsing support for it for now.</div>
<div><br></div><div>- Will.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>On 10 January 2013 15:39, Aaron Ballman <span dir="ltr"><<a href="mailto:aaron@aaronballman.com" target="_blank">aaron@aaronballman.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>I should also note that I'm seeing a couple of warnings in your patch as well:<br>
<br>
warning C4062: enumerator 'MSProperty' in switch of enum<br>
'clang::Decl::Kind' is not handled<br>
C:\llvm\llvm\tools\clang\tools\libclang\CIndex.cpp 4545<br>
<br>
warning C4062: enumerator 'MSPropertyRefExprClass' in switch of enum<br>
'clang::Stmt::StmtClass' is not handled<br>
C:\llvm\llvm\tools\clang\tools\libclang\CXCursor.cpp 486<br>
</div></div><div><div><br>
~Aaron<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><span><font color="#888888"><br>
</font></span></div></div></blockquote></div><span><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div><span style="color:rgb(68,68,68);font-family:Arial,Helvetica,sans-serif"><b>Indefiant Ltd.</b></span></div>
<div>
<font color="#444444" face="Arial, Helvetica, sans-serif"><span style="font-size:12px"><b><br></b></span></font></div><font color="#444444" face="Arial, Helvetica, sans-serif"><span style="font-size:12px">Firsby Lodge, New Main Road, Scamblesby, Louth, Lincs LN11 9XH UK<br>
</span></font><div style="padding-left:0px;padding-right:0px;padding-top:0px;margin-right:0px;margin-left:0px;margin-bottom:0px;margin-top:0px;padding-bottom:0px"><span style="color:rgb(68,68,68);font-family:Arial,Helvetica,sans-serif;font-size:x-small"><i>Tel: <a href="tel:%2B44%2020%208123%207663" value="+442081237663" target="_blank">+44 20 8123 7663</a> England Registered No. <a href="tel:07936820" value="+497936820" target="_blank">07936820</a> VAT No. </i></span><span style="background-color:transparent"><font color="#444444" face="Arial, Helvetica, sans-serif" size="1"><i>128556202</i></font></span></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div></div></div><div>-- <br>Best Regards, Tong Shen (沈彤)
</div></div>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div></div></div><br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><span style="background-color:rgb(255,255,255);color:rgb(68,68,68);font-family:Arial,Helvetica,sans-serif"><b>Indefiant Ltd.</b></span></div><div><font color="#444444" face="Arial, Helvetica, sans-serif"><span style="font-size:12px"><b><br>
</b></span></font></div><font color="#444444" face="Arial, Helvetica, sans-serif"><span style="font-size:12px">Firsby Lodge, New Main Road, Scamblesby, Louth, Lincs LN11 9XH UK<br></span></font><div style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;padding-top:0px;padding-right:0px;padding-bottom:0px;padding-left:0px;background-color:rgb(255,255,255)">
<span style="color:rgb(68,68,68);font-family:Arial,Helvetica,sans-serif;font-size:x-small"><i>Tel: +44 20 8123 7663 England Registered No. 07936820 VAT No. </i></span><span style="background-color:transparent"><font color="#444444" face="Arial, Helvetica, sans-serif" size="1"><i>128556202</i></font></span></div>
</div>