<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Sure, r178274. Thanks!</div><div>Jordan</div><br><div><div>On Mar 28, 2013, at 11:31 , Alexander Zinenko <<a href="mailto:ftynse@gmail.com">ftynse@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">I don't have commit access yet. Would you mind committing it for me?</div><div class="gmail_extra"><br><br><div class="gmail_quote">On 28 March 2013 20:20, Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>LGTM, go ahead and commit!</div><div>Jordan</div><br><div><div><div class="h5">
<div>
On Mar 28, 2013, at 11:13 , Alexander Zinenko <<a href="mailto:ftynse@gmail.com" target="_blank">ftynse@gmail.com</a>> wrote:</div><br></div></div><blockquote type="cite"><div><div class="h5"><div dir="ltr">Indeed, thanks!<div>
Sorry that such a simple patch takes so much time.<br><div>Here is the updated one.<br><div class="gmail_extra"><br><div class="gmail_quote">On 28 March 2013 19:53, Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>Actually, I just realized that the SourceRange here is a token range, so CreateReplacement will do the right thing even if you just pass a single location. (I realized this because you shouldn't have to do the -1 offset; CharSourceRange is a half-open range like other C++ ranges.)</div>
<div><br></div><div>Jordan</div><div><br></div><div><br></div></div></blockquote></div></div></div></div></div>
</div></div><span><13824fixit.patch></span></blockquote></div><br></div>
</blockquote></div><br></div>
</blockquote></div><br></body></html>