<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>We are a <i>long</i> way from that being true. One more violation won't hurt today. (A quick search shows the same technique being used in Sema::CheckMain.)</div><div><br></div><div>Jordan</div><div><br></div><br><div><div>On Mar 28, 2013, at 10:03 , Alexander Zinenko <<a href="mailto:ftynse@gmail.com">ftynse@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div style="">SemaDecl.cpp comment says</div><div style=""><br></div><div>#include "clang/Lex/Preprocessor.h" // FIXME: Sema shouldn't depend on Lex</div><div><br></div><div style="">that's why I didn't use it. Is it ok to use Preprocessor in Sema?</div>
<div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 28 March 2013 18:47, Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I don't think you actually need to pass the range around. PP.getLocForEndOfToken should work fine. (Sorry I didn't notice this the first time around.)<br>
<div><div class="h5"><br>
On Mar 28, 2013, at 9:35 , Alexander Zinenko <<a href="mailto:ftynse@gmail.com">ftynse@gmail.com</a>> wrote:<br>
<br>
> Hello<br>
><br>
> This patch adds fixits to -Wreinterpret-base-class proposing to replace reinterpret_cast with static_cast. It required passing SourceRange instead of SourceLocation through some calls in Sema.<br>
><br>
> Review please!<br>
><br>
> --<br>
> Alex<br>
><br>
</div></div>> <13824fixit.patch>_______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
</blockquote></div><br></div>
</blockquote></div><br></body></html>