<div>+ // Parse _Static_assert declaration.</div><div>+ if (Tok.is(tok::kw_static_assert) || Tok.is(tok::kw__Static_assert)) {</div><div><br></div><div>Any reason to check for _Static_assert here? This code is not reachable in C++.</div>
<div><br></div><div><div>+++ clang/test/Sema/static-assert2.c</div></div><div><br></div><div>Please add the tests to test/Sema/static-assert.c instead. We don't need to run these tests in C++ mode; we already have good coverage for C++11's static_assert.</div>
<br><div class="gmail_quote">On Wed, Mar 27, 2013 at 9:13 AM, Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div>It looks like it is not an extension (C11 6.7.2.1p1), so you're good.</div><div><br></div><div>I don't see any problems with this but you should wait for someone more commonly in Parse than I am.</div>
<div><br></div><div>Jordan</div><div><br></div><br><div><div class="im"><div>On Mar 27, 2013, at 8:14 , Sean Silva <<a href="mailto:silvas@purdue.edu" target="_blank">silvas@purdue.edu</a>> wrote:</div><br></div><blockquote type="cite">
<div class="im"><div dir="ltr">Adding language extensions should be accompanied by a modification of <<a href="http://clang.llvm.org/docs/LanguageExtensions.html" target="_blank">http://clang.llvm.org/docs/LanguageExtensions.html</a>> (clang/docs/LanguageExtensions.rst).<div>
<br></div><div>-- Sean Silva</div></div></div>
_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br>