<div>+++ b/lib/Sema/SemaExprCXX.cpp</div><div><div>@@ -2952,6 +2955,42 @@ static bool CheckUnaryTypeTraitTypeCompleteness(Sema &S,</div></div><div>[...]</div><div>+ CXXRecordDecl* RD = cast<CXXRecordDecl>(RT->getDecl());</div>
<div><br></div><div>Should be " *", not "* ".</div><div><br></div><div>+ if((RD->*HasTrivial)() && !(RD->*HasNonTrivial)())</div><div>+ return true;</div><div><br></div><div>Missing space after 'if'.</div>
<div><br></div><div><div>+ // This trait is implemented by MSVC 2012 and needed to parse the</div><div>+ // standard library headers. Specifically this is used as the logic</div><div>+ // behind std::has_trivial_move_constructor (20.9.4.3).</div>
</div><div><br></div><div>The trait is called std::is_trivial_move_constructible.</div><div><br></div><div>Otherwise, LGTM! Thanks for picking this up.</div><br><div class="gmail_quote">On Fri, Mar 22, 2013 at 4:51 AM, Aaron Ballman <span dir="ltr"><<a href="mailto:aaron@aaronballman.com" target="_blank">aaron@aaronballman.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Changes LGTM based on Richard's suggestions. Waiting to make sure<br>
Richard agrees. :-)<br>
<span class="HOEnZb"><font color="#888888"><br>
~Aaron<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On Thu, Mar 21, 2013 at 10:58 AM, Joćo Matos <<a href="mailto:ripzonetriton@gmail.com">ripzonetriton@gmail.com</a>> wrote:<br>
> On Sat, Jan 19, 2013 at 2:12 AM, Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>><br>
> wrote:<br>
>><br>
>> Sorry for the delay! Just a handful of things:<br>
><br>
><br>
> Hi Richard, I did the changes you requested.<br>
><br>
> <a href="http://llvm-reviews.chandlerc.com/D567" target="_blank">http://llvm-reviews.chandlerc.com/D567</a><br>
><br>
> --<br>
> Joćo Matos<br>
</div></div><div class="HOEnZb"><div class="h5">> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
><br>
</div></div></blockquote></div><br>