<div dir="ltr">Is this patch good to go, or did I add too much to it?  In particular, I had to make changes to the clang attribute tablegen, so I'd rather not commit that without review.<div><div class="gmail_extra"><br>
<br><div class="gmail_quote">On Fri, Mar 22, 2013 at 4:50 PM, Reid Kleckner <span dir="ltr"><<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
    - Implement John's comments.<br>
<div class="im"><br>
Hi rjmccall,<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D568" target="_blank">http://llvm-reviews.chandlerc.com/D568</a><br>
<br>
CHANGE SINCE LAST DIFF<br>
</div>  <a href="http://llvm-reviews.chandlerc.com/D568?vs=1374&id=1376#toc" target="_blank">http://llvm-reviews.chandlerc.com/D568?vs=1374&id=1376#toc</a><br>
<br>
Files:<br>
  include/clang/AST/Attr.h<br>
  include/clang/Basic/Attr.td<br>
  include/clang/Basic/AttrKinds.h<br>
  lib/AST/ASTContext.cpp<br>
  lib/AST/AttrImpl.cpp<br>
  lib/AST/CXXABI.h<br>
  lib/AST/ItaniumCXXABI.cpp<br>
  lib/AST/MicrosoftCXXABI.cpp<br>
  lib/Sema/SemaType.cpp<br>
  test/SemaCXX/member-pointer-ms.cpp<br>
  utils/TableGen/ClangAttrEmitter.cpp<br>
</blockquote></div><br></div></div></div>