<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">on2013/3/24 10:05, Sean Silva wrote:<br>
</div>
<blockquote
cite="mid:CAHnXoam4qtq=mVCaBxSLEVehYXuLQNzMXvuW-RQ1hNhpKHjJOQ@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra">
<div class="gmail_quote">
<div style="">The AArch64 backend was committed fairly
quickly after being proposed for inclusion, and they did
not split up the patch and most of their backend was
committed in one huge commit.</div>
<div style=""><br>
</div>
<div style="">Although IIRC Bill Wendling (CC'd) explicitly
asked you to split the backend into separate patches, it
might be best to put it back together again for the final
review. AFAIK Phabricator does not have a good way to keep
all the patches somehow together, and otherwise they just
get lost in people's mail (and it would be annoying to
ping 10+ patches). Having a single patch avoids this
problem and makes it a lot easier to keep track of the
backend. Phabricator has good support for commenting on
specific parts of the patch, so as long as the backend
components are named in a recognizable way (I think they
are), experienced reviewers should not have significant
difficulty navigating (and they can always apply the patch
locally if necessary, which is easier with one huge
patch).</div>
<div style=""><br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
Hi Sean,<br>
<br>
I appreicate your objective comments here.<br>
<br>
Anyway, I just finished rebase and retest TILE-Gx backend on
the latest llvm mainline, and will re-send the patch on Phabricator
for final review.<br>
<br>
---<br>
Regards,<br>
Jiong<br>
Tilera Corporation <br>
<br>
<blockquote
cite="mid:CAHnXoam4qtq=mVCaBxSLEVehYXuLQNzMXvuW-RQ1hNhpKHjJOQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div style="">-- Sean Silva</div>
</div>
<br>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
LLVM Developers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <a class="moz-txt-link-freetext" href="http://llvm.cs.uiuc.edu">http://llvm.cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a>
</pre>
</blockquote>
<br>
</body>
</html>