Hi John,<br><br><div class="gmail_quote">On Thu, Mar 21, 2013 at 7:58 PM, John McCall <span dir="ltr"><<a href="mailto:rjmccall@apple.com" target="_blank">rjmccall@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: rjmccall<br>
Date: Thu Mar 21 21:58:14 2013<br>
New Revision: 177698<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=177698&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=177698&view=rev</a><br>
Log:<br>
Warn about attempts to reinterpret_cast between two types that are<br>
hierarchy-related at a possibly nonzero offset.<br>
<br>
Patch by Alexander Zinenko!<br>
<br>
Added:<br>
cfe/trunk/test/SemaCXX/warn-reinterpret-base-class.cpp<br>
Modified:<br>
cfe/trunk/include/clang/Basic/DiagnosticGroups.td<br>
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
cfe/trunk/lib/Sema/SemaCast.cpp<br>
<br>
Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=177698&r1=177697&r2=177698&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=177698&r1=177697&r2=177698&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original)<br>
+++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Thu Mar 21 21:58:14 2013<br>
@@ -266,6 +266,7 @@ def Trigraphs : DiagGroup<"trigraph<br>
<br>
def : DiagGroup<"type-limits">;<br>
def UndefinedReinterpretCast : DiagGroup<"undefined-reinterpret-cast">;<br>
+def ReinterpretBaseClass : DiagGroup<"reinterpret-base-class">;<br>
def Unicode : DiagGroup<"unicode">;<br>
def UninitializedMaybe : DiagGroup<"conditional-uninitialized">;<br>
def UninitializedSometimes : DiagGroup<"sometimes-uninitialized">;<br>
<br>
Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=177698&r1=177697&r2=177698&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=177698&r1=177697&r2=177698&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)<br>
+++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Thu Mar 21 21:58:14 2013<br>
@@ -4491,6 +4491,14 @@ def note_parameter_here : Note<<br>
def err_bad_reinterpret_cast_overload : Error<<br>
"reinterpret_cast cannot resolve overloaded function %0 to type %1">;<br>
<br>
+def warn_reinterpret_different_from_static : Warning<<br>
+ "'reinterpret_cast' %select{from|to}3 class %0 %select{to|from}3 its "<br>
+ "%select{virtual base|base at non-zero offset}2 %1 behaves differently from "<br>
+ "'static_cast'">, InGroup<ReinterpretBaseClass>;<br>
+def note_reinterpret_updowncast_use_static: Note<<br>
+ "use 'static_cast' to adjust the pointer correctly while "<br>
+ "%select{upcasting|downcasting}0">;<br>
+<br>
def err_bad_static_cast_overload : Error<<br>
"address of overloaded function %0 cannot be static_cast to type %1">;<br>
<br>
<br>
Modified: cfe/trunk/lib/Sema/SemaCast.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaCast.cpp?rev=177698&r1=177697&r2=177698&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaCast.cpp?rev=177698&r1=177697&r2=177698&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaCast.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaCast.cpp Thu Mar 21 21:58:14 2013<br>
@@ -19,6 +19,7 @@<br>
#include "clang/AST/CXXInheritance.h"<br>
#include "clang/AST/ExprCXX.h"<br>
#include "clang/AST/ExprObjC.h"<br>
+#include "clang/AST/RecordLayout.h"<br>
#include "clang/Basic/PartialDiagnostic.h"<br>
#include "clang/Sema/Initialization.h"<br>
#include "llvm/ADT/SmallVector.h"<br>
@@ -682,6 +683,88 @@ void CastOperation::CheckConstCast() {<br>
<< SrcExpr.get()->getType() << DestType << OpRange;<br>
}<br>
<br>
+/// Check that a reinterpret_cast\<DestType\>(SrcExpr) is not used as upcast<br>
+/// or downcast between respective pointers or references.<br>
+static void DiagnoseReinterpretUpDownCast(Sema &Self, const Expr *SrcExpr,<br>
+ QualType DestType,<br>
+ SourceRange OpRange) {<br>
+ QualType SrcType = SrcExpr->getType();<br>
+ // When casting from pointer or reference, get pointee type; use original<br>
+ // type otherwise.<br>
+ const CXXRecordDecl *SrcPointeeRD = SrcType->getPointeeCXXRecordDecl();<br>
+ const CXXRecordDecl *SrcRD =<br>
+ SrcPointeeRD ? SrcPointeeRD : SrcType->getAsCXXRecordDecl();<br>
+<br>
+ // Examining subobjects for records is only possible if the complete<br>
+ // definition is available. Also, template instantiation is not allowed here.<br>
+ if(!SrcRD || !SrcRD->isCompleteDefinition())<br>
+ return;<br>
+<br>
+ const CXXRecordDecl *DestRD = DestType->getPointeeCXXRecordDecl();<br>
+<br>
+ if(!DestRD || !DestRD->isCompleteDefinition())<br>
+ return;<br>
+<br>
+ enum {<br>
+ ReinterpretUpcast,<br>
+ ReinterpretDowncast<br>
+ } ReinterpretKind;<br>
+<br>
+ CXXBasePaths BasePaths;<br>
+<br>
+ if (SrcRD->isDerivedFrom(DestRD, BasePaths))<br>
+ ReinterpretKind = ReinterpretUpcast;<br>
+ else if (DestRD->isDerivedFrom(SrcRD, BasePaths))<br>
+ ReinterpretKind = ReinterpretDowncast;<br>
+ else<br>
+ return;<br>
+<br>
+ bool VirtualBase = true;<br>
+ bool NonZeroOffset = false;<br>
+ for (CXXBasePaths::const_paths_iterator I = BasePaths.begin(),<br>
+ E = BasePaths.end();<br>
+ I != E; ++I) {<br>
+ const CXXBasePath &Path = *I;<br>
+ CharUnits Offset = CharUnits::Zero();<br>
+ bool IsVirtual = false;<br>
+ for (CXXBasePath::const_iterator IElem = Path.begin(), EElem = Path.end();<br>
+ IElem != EElem; ++IElem) {<br>
+ IsVirtual = IElem->Base->isVirtual();<br>
+ if (IsVirtual)<br>
+ break;<br>
+ const CXXRecordDecl *BaseRD = IElem->Base->getType()->getAsCXXRecordDecl();<br>
+ assert(BaseRD && "Base type should be a valid unqualified class type");<br>
+ const ASTRecordLayout &DerivedLayout =<br>
+ Self.Context.getASTRecordLayout(IElem->Class);<br></blockquote><div><br></div><div>We have a crash-on-invalid here. Testcase:</div><div><br></div><div>struct A;</div><div>struct B { A a; };</div><div>struct C : B {} c;</div>
<div>B *p = reinterpret_cast<B*>(&c);</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+ Offset += DerivedLayout.getBaseClassOffset(BaseRD);<br>
+ }<br>
+ if (!IsVirtual) {<br>
+ // Don't warn if any path is a non-virtually derived base at offset zero.<br>
+ if (Offset.isZero())<br>
+ return;<br>
+ // Offset makes sense only for non-virtual bases.<br>
+ else<br>
+ NonZeroOffset = true;<br>
+ }<br>
+ VirtualBase = VirtualBase && IsVirtual;<br>
+ }<br>
+<br>
+ assert((VirtualBase || NonZeroOffset) &&<br>
+ "Should have returned if has non-virtual base with zero offset");<br>
+<br>
+ QualType BaseType =<br>
+ ReinterpretKind == ReinterpretUpcast? DestType : SrcType;<br>
+ QualType DerivedType =<br>
+ ReinterpretKind == ReinterpretUpcast? SrcType : DestType;<br>
+<br>
+ Self.Diag(OpRange.getBegin(), diag::warn_reinterpret_different_from_static)<br>
+ << DerivedType << BaseType << !VirtualBase << ReinterpretKind;<br>
+ Self.Diag(OpRange.getBegin(), diag::note_reinterpret_updowncast_use_static)<br>
+ << ReinterpretKind;<br>
+<br>
+ // TODO: emit fixits. This requires passing operator SourceRange from Parser.<br>
+}<br>
+<br>
/// CheckReinterpretCast - Check that a reinterpret_cast\<DestType\>(SrcExpr) is<br>
/// valid.<br>
/// Refer to C++ 5.2.10 for details. reinterpret_cast is typically used in code<br>
@@ -714,8 +797,10 @@ void CastOperation::CheckReinterpretCast<br>
diagnoseBadCast(Self, msg, CT_Reinterpret, OpRange, SrcExpr.get(),<br>
DestType, /*listInitialization=*/false);<br>
}<br>
- } else if (tcr == TC_Success && Self.getLangOpts().ObjCAutoRefCount) {<br>
- checkObjCARCConversion(Sema::CCK_OtherCast);<br>
+ } else if (tcr == TC_Success) {<br>
+ if (Self.getLangOpts().ObjCAutoRefCount)<br>
+ checkObjCARCConversion(Sema::CCK_OtherCast);<br>
+ DiagnoseReinterpretUpDownCast(Self, SrcExpr.get(), DestType, OpRange);<br>
}<br>
}<br>
<br>
<br>
Added: cfe/trunk/test/SemaCXX/warn-reinterpret-base-class.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/warn-reinterpret-base-class.cpp?rev=177698&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/warn-reinterpret-base-class.cpp?rev=177698&view=auto</a><br>
==============================================================================<br>
--- cfe/trunk/test/SemaCXX/warn-reinterpret-base-class.cpp (added)<br>
+++ cfe/trunk/test/SemaCXX/warn-reinterpret-base-class.cpp Thu Mar 21 21:58:14 2013<br>
@@ -0,0 +1,234 @@<br>
+// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify -Wreinterpret-base-class -Wno-unused-volatile-lvalue %s<br>
+<br>
+// PR 13824<br>
+class A {<br>
+};<br>
+class DA : public A {<br>
+};<br>
+class DDA : public DA {<br>
+};<br>
+class DAo : protected A {<br>
+};<br>
+class DAi : private A {<br>
+};<br>
+<br>
+class DVA : public virtual A {<br>
+};<br>
+class DDVA : public virtual DA {<br>
+};<br>
+class DMA : public virtual A, public virtual DA {<br>
+};<br>
+<br>
+class B;<br>
+<br>
+struct C {<br>
+ // Do not fail on incompletely-defined classes.<br>
+ decltype(reinterpret_cast<C *>(0)) foo;<br>
+ decltype(reinterpret_cast<A *>((C *) 0)) bar;<br>
+ decltype(reinterpret_cast<C *>((A *) 0)) baz;<br>
+};<br>
+<br>
+void reinterpret_not_defined_class(B *b, C *c) {<br>
+ // Should not fail if class has no definition.<br>
+ (void)*reinterpret_cast<C *>(b);<br>
+ (void)*reinterpret_cast<B *>(c);<br>
+<br>
+ (void)reinterpret_cast<C &>(*b);<br>
+ (void)reinterpret_cast<B &>(*c);<br>
+}<br>
+<br>
+void reinterpret_not_updowncast(A *pa, const A *pca, A &a, const A &ca) {<br>
+ (void)*reinterpret_cast<C *>(pa);<br>
+ (void)*reinterpret_cast<const C *>(pa);<br>
+ (void)*reinterpret_cast<volatile C *>(pa);<br>
+ (void)*reinterpret_cast<const volatile C *>(pa);<br>
+<br>
+ (void)*reinterpret_cast<const C *>(pca);<br>
+ (void)*reinterpret_cast<const volatile C *>(pca);<br>
+<br>
+ (void)reinterpret_cast<C &>(a);<br>
+ (void)reinterpret_cast<const C &>(a);<br>
+ (void)reinterpret_cast<volatile C &>(a);<br>
+ (void)reinterpret_cast<const volatile C &>(a);<br>
+<br>
+ (void)reinterpret_cast<const C &>(ca);<br>
+ (void)reinterpret_cast<const volatile C &>(ca);<br>
+}<br>
+<br>
+void reinterpret_pointer_downcast(A *a, const A *ca) {<br>
+ (void)*reinterpret_cast<DA *>(a);<br>
+ (void)*reinterpret_cast<const DA *>(a);<br>
+ (void)*reinterpret_cast<volatile DA *>(a);<br>
+ (void)*reinterpret_cast<const volatile DA *>(a);<br>
+<br>
+ (void)*reinterpret_cast<const DA *>(ca);<br>
+ (void)*reinterpret_cast<const volatile DA *>(ca);<br>
+<br>
+ (void)*reinterpret_cast<DDA *>(a);<br>
+ (void)*reinterpret_cast<DAo *>(a);<br>
+ (void)*reinterpret_cast<DAi *>(a);<br>
+ // expected-warning@+2 {{'reinterpret_cast' to class 'DVA *' from its virtual base 'A *' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while downcasting}}<br>
+ (void)*reinterpret_cast<DVA *>(a);<br>
+ // expected-warning@+2 {{'reinterpret_cast' to class 'DDVA *' from its virtual base 'A *' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while downcasting}}<br>
+ (void)*reinterpret_cast<DDVA *>(a);<br>
+ // expected-warning@+2 {{'reinterpret_cast' to class 'DMA *' from its virtual base 'A *' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while downcasting}}<br>
+ (void)*reinterpret_cast<DMA *>(a);<br>
+}<br>
+<br>
+void reinterpret_reference_downcast(A a, A &ra, const A &cra) {<br>
+ (void)reinterpret_cast<DA &>(a);<br>
+ (void)reinterpret_cast<const DA &>(a);<br>
+ (void)reinterpret_cast<volatile DA &>(a);<br>
+ (void)reinterpret_cast<const volatile DA &>(a);<br>
+<br>
+ (void)reinterpret_cast<DA &>(ra);<br>
+ (void)reinterpret_cast<const DA &>(ra);<br>
+ (void)reinterpret_cast<volatile DA &>(ra);<br>
+ (void)reinterpret_cast<const volatile DA &>(ra);<br>
+<br>
+ (void)reinterpret_cast<const DA &>(cra);<br>
+ (void)reinterpret_cast<const volatile DA &>(cra);<br>
+<br>
+ (void)reinterpret_cast<DDA &>(a);<br>
+ (void)reinterpret_cast<DAo &>(a);<br>
+ (void)reinterpret_cast<DAi &>(a);<br>
+ // expected-warning@+2 {{'reinterpret_cast' to class 'DVA &' from its virtual base 'A' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while downcasting}}<br>
+ (void)reinterpret_cast<DVA &>(a);<br>
+ // expected-warning@+2 {{'reinterpret_cast' to class 'DDVA &' from its virtual base 'A' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while downcasting}}<br>
+ (void)reinterpret_cast<DDVA &>(a);<br>
+ // expected-warning@+2 {{'reinterpret_cast' to class 'DMA &' from its virtual base 'A' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while downcasting}}<br>
+ (void)reinterpret_cast<DMA &>(a);<br>
+}<br>
+<br>
+void reinterpret_pointer_upcast(DA *da, const DA *cda, DDA *dda, DAo *dao,<br>
+ DAi *dai, DVA *dva, DDVA *ddva, DMA *dma) {<br>
+ (void)*reinterpret_cast<A *>(da);<br>
+ (void)*reinterpret_cast<const A *>(da);<br>
+ (void)*reinterpret_cast<volatile A *>(da);<br>
+ (void)*reinterpret_cast<const volatile A *>(da);<br>
+<br>
+ (void)*reinterpret_cast<const A *>(cda);<br>
+ (void)*reinterpret_cast<const volatile A *>(cda);<br>
+<br>
+ (void)*reinterpret_cast<A *>(dda);<br>
+ (void)*reinterpret_cast<DA *>(dda);<br>
+ (void)*reinterpret_cast<A *>(dao);<br>
+ (void)*reinterpret_cast<A *>(dai);<br>
+ // expected-warning@+2 {{'reinterpret_cast' from class 'DVA *' to its virtual base 'A *' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while upcasting}}<br>
+ (void)*reinterpret_cast<A *>(dva);<br>
+ // expected-warning@+2 {{'reinterpret_cast' from class 'DDVA *' to its virtual base 'A *' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while upcasting}}<br>
+ (void)*reinterpret_cast<A *>(ddva);<br>
+ // expected-warning@+2 {{'reinterpret_cast' from class 'DDVA *' to its virtual base 'DA *' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while upcasting}}<br>
+ (void)*reinterpret_cast<DA *>(ddva);<br>
+ // expected-warning@+2 {{'reinterpret_cast' from class 'DMA *' to its virtual base 'A *' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while upcasting}}<br>
+ (void)*reinterpret_cast<A *>(dma);<br>
+ // expected-warning@+2 {{'reinterpret_cast' from class 'DMA *' to its virtual base 'DA *' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while upcasting}}<br>
+ (void)*reinterpret_cast<DA *>(dma);<br>
+}<br>
+<br>
+void reinterpret_reference_upcast(DA &da, const DA &cda, DDA &dda, DAo &dao,<br>
+ DAi &dai, DVA &dva, DDVA &ddva, DMA &dma) {<br>
+ (void)reinterpret_cast<A &>(da);<br>
+ (void)reinterpret_cast<const A &>(da);<br>
+ (void)reinterpret_cast<volatile A &>(da);<br>
+ (void)reinterpret_cast<const volatile A &>(da);<br>
+<br>
+ (void)reinterpret_cast<const A &>(cda);<br>
+ (void)reinterpret_cast<const volatile A &>(cda);<br>
+<br>
+ (void)reinterpret_cast<A &>(dda);<br>
+ (void)reinterpret_cast<DA &>(dda);<br>
+ (void)reinterpret_cast<A &>(dao);<br>
+ (void)reinterpret_cast<A &>(dai);<br>
+ // expected-warning@+2 {{'reinterpret_cast' from class 'DVA' to its virtual base 'A &' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while upcasting}}<br>
+ (void)reinterpret_cast<A &>(dva);<br>
+ // expected-warning@+2 {{'reinterpret_cast' from class 'DDVA' to its virtual base 'A &' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while upcasting}}<br>
+ (void)reinterpret_cast<A &>(ddva);<br>
+ // expected-warning@+2 {{'reinterpret_cast' from class 'DDVA' to its virtual base 'DA &' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while upcasting}}<br>
+ (void)reinterpret_cast<DA &>(ddva);<br>
+ // expected-warning@+2 {{'reinterpret_cast' from class 'DMA' to its virtual base 'A &' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while upcasting}}<br>
+ (void)reinterpret_cast<A &>(dma);<br>
+ // expected-warning@+2 {{'reinterpret_cast' from class 'DMA' to its virtual base 'DA &' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while upcasting}}<br>
+ (void)reinterpret_cast<DA &>(dma);<br>
+}<br>
+<br>
+struct E {<br>
+ int x;<br>
+};<br>
+<br>
+class F : public E {<br>
+ virtual int foo() { return x; }<br>
+};<br>
+<br>
+class G : public F {<br>
+};<br>
+<br>
+class H : public E, public A {<br>
+};<br>
+<br>
+class I : virtual public F {<br>
+};<br>
+<br>
+typedef const F * K;<br>
+typedef volatile K L;<br>
+<br>
+void different_subobject_downcast(E *e, F *f, A *a) {<br>
+ // expected-warning@+2 {{'reinterpret_cast' to class 'F *' from its base at non-zero offset 'E *' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while downcasting}}<br>
+ (void)reinterpret_cast<F *>(e);<br>
+ // expected-warning@+2 {{'reinterpret_cast' to class 'G *' from its base at non-zero offset 'E *' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while downcasting}}<br>
+ (void)reinterpret_cast<G *>(e);<br>
+ (void)reinterpret_cast<H *>(e);<br>
+ // expected-warning@+2 {{'reinterpret_cast' to class 'I *' from its virtual base 'E *' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while downcasting}}<br>
+ (void)reinterpret_cast<I *>(e);<br>
+<br>
+ (void)reinterpret_cast<G *>(f);<br>
+ // expected-warning@+2 {{'reinterpret_cast' to class 'I *' from its virtual base 'F *' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while downcasting}}<br>
+ (void)reinterpret_cast<I *>(f);<br>
+<br>
+ (void)reinterpret_cast<H *>(a);<br>
+<br>
+ // expected-warning@+2 {{'reinterpret_cast' to class 'L' (aka 'const F *volatile') from its base at non-zero offset 'E *' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while downcasting}}<br>
+ (void)reinterpret_cast<L>(e);<br>
+}<br>
+<br>
+void different_subobject_upcast(F *f, G *g, H *h, I *i) {<br>
+ // expected-warning@+2 {{'reinterpret_cast' from class 'F *' to its base at non-zero offset 'E *' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while upcasting}}<br>
+ (void)reinterpret_cast<E *>(f);<br>
+<br>
+ (void)reinterpret_cast<F *>(g);<br>
+ // expected-warning@+2 {{'reinterpret_cast' from class 'G *' to its base at non-zero offset 'E *' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while upcasting}}<br>
+ (void)reinterpret_cast<E *>(g);<br>
+<br>
+ (void)reinterpret_cast<E *>(h);<br>
+ (void)reinterpret_cast<A *>(h);<br>
+<br>
+ // expected-warning@+2 {{'reinterpret_cast' from class 'I *' to its virtual base 'F *' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while upcasting}}<br>
+ (void)reinterpret_cast<F *>(i);<br>
+ // expected-warning@+2 {{'reinterpret_cast' from class 'I *' to its virtual base 'E *' behaves differently from 'static_cast'}}<br>
+ // expected-note@+1 {{use 'static_cast' to adjust the pointer correctly while upcasting}}<br>
+ (void)reinterpret_cast<E *>(i);<br>
+}<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br>