<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Mar 22, 2013, at 9:58 AM, Reid Kleckner <<a href="mailto:rnk@google.com">rnk@google.com</a>> wrote:</div><blockquote type="cite"><div dir="ltr">On Thu, Mar 21, 2013 at 11:14 PM, John McCall <span dir="ltr"><<a href="mailto:rjmccall@apple.com" target="_blank">rjmccall@apple.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"><span style="color:rgb(34,34,34)">All these tests are pretty inadequate; you could be accidentally doing</span><br>
</div>
a lot of stuff besides the stores. You should basically be testing the entire<br>
function body, including the define line. This will also let you effectively<br>
test that you're generating the right IR type, which will be important when<br>
you start generating different IR types for different cases.<br></blockquote><div><br></div><div style="">OK, now the alloca and its size is part of the test. That should constrain the size of the member pointer to a single slot.</div></div></div></div></blockquote><div><br></div><div>Might as well use CHECK-NEXT for everything after the first alloca line.</div><div>With that, feel free to commit, thanks!</div><br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
You're also not testing the generation of a null value.<br></blockquote><div><br></div><div style="">How so? That's what the final store -1/0 is in each function.</div></div></div></div>
</blockquote></div><br><div>Oh, sorry, I think I missed that somehow.</div><div><br></div><div>John.</div></body></html>