<div dir="ltr">On 17 March 2013 19:10, Andrew Turner <span dir="ltr"><<a href="mailto:andrew@fubar.geek.nz" target="_blank">andrew@fubar.geek.nz</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">> You're changing both EABI and GNUEABI but only testing one of them.<br>
</div>I can add a test for EABI but only GNUEABI will be supported on FreeBSD.<br></blockquote><div><br></div><div style>It's weird, I agree. It should be safe to print version 5 on Clang's binaries, since every new release should be backwards compatible, as is 5 with the previous.</div>
<div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">How? When using an external assembler the the ABI version is sever<br></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
passed to it so will be 0.<br></blockquote><div><br></div><div style>-Wa?</div><div style><br></div><div style>Anyhow, I think I agree with Anton that the patch is harmless for most cases and beneficial to your case. I can't think of a way where it would be bad or break current code, maybe I was just being over cautious.</div>
<div style><br></div><div style>Feel free to commit.</div><div style><br></div><div style>cheers,</div><div style>--renato</div></div></div></div>