<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 3/6/2013 11:12 AM, Daniel Dunbar
wrote:<br>
</div>
<blockquote
cite="mid:CAEU8z6_wS17-yAJyXobGwUyM97N38ctQGJVAya9htx51Hnq4Ew@mail.gmail.com"
type="cite">
<div dir="ltr">Hi Matthew,
<div><br>
</div>
<div style="">Is the motivation just as a cleanup?</div>
</div>
</blockquote>
Primarily cleanup, though we have an internal project that involves
adding a new phase. This makes it a little more straightforward to
do so.<br>
<blockquote
cite="mid:CAEU8z6_wS17-yAJyXobGwUyM97N38ctQGJVAya9htx51Hnq4Ew@mail.gmail.com"
type="cite">
<div dir="ltr">
<div style=""><br>
</div>
<div style="">Specific comments on the patch:</div>
<div style=""><br>
</div>
<div style="">1. getCompilationPhases should take the phase list
as a reference not a pointer, this is more consistent.</div>
<div style=""><br>
</div>
<div style="">2. Don't .clear() the list in
getCompilationPhases.</div>
<div style=""><br>
</div>
<div style="">3. There aren't enough uses to be worth
introducing the PhaseList type, just write out the SmallVector
which makes the code more verbose but more familiar.</div>
<div style=""><br>
</div>
</div>
</blockquote>
New patch attached incorporating this feedback.<br>
<br>
Thanks for the review!<br>
Matthew Curtis<br>
<br>
<blockquote
cite="mid:CAEU8z6_wS17-yAJyXobGwUyM97N38ctQGJVAya9htx51Hnq4Ew@mail.gmail.com"
type="cite">
<div dir="ltr">
<div style=""> - Daniel</div>
<div style=""><br>
</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Wed, Mar 6, 2013 at 6:04 AM, Matthew
Curtis <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:mcurtis@codeaurora.org" target="_blank">mcurtis@codeaurora.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div>Hello Daniel,<br>
<br>
Do you have time to comment on this patch?<br>
<br>
Thanks,<br>
Matthew Curtis.
<div class="im"><br>
<br>
On 3/1/2013 4:17 PM, Matthew Curtis wrote:<br>
</div>
</div>
<blockquote type="cite">
<div class="im">There is now a single function to get
the list of phases for a given <br>
output Type. <br>
<br>
No functionality change intended. <br>
<br>
Thanks, <br>
Matthew Curtis <br>
<br>
<br>
<fieldset></fieldset>
<br>
</div>
<pre>_______________________________________________
cfe-commits mailing list
<a moz-do-not-send="true" href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a>
<a moz-do-not-send="true" href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a>
</pre>
</blockquote>
<div class="im"> <br>
<br>
<pre cols="72">--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation</pre>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation</pre>
</body>
</html>