<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Feb 28, 2013, at 14:36 , Fariborz Jahanian <<a href="mailto:fjahanian@apple.com">fjahanian@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;">Author: fjahanian<br>Date: Thu Feb 28 16:36:31 2013<br>New Revision: 176303<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=176303&view=rev">http://llvm.org/viewvc/llvm-project?rev=176303&view=rev</a><br>Log:<br>objective-C: clang, following gcc, warns on<br>use of stand-alone protocol as type and uses<br>id<proto>. Modify warning to say what compiler<span class="Apple-converted-space"> </span><br>is doing. // rdar//13158394<br><br>Modified:<br> cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td<br> cfe/trunk/test/FixIt/fixit-objc.m<br> cfe/trunk/test/Parser/placeholder-recovery.m<br> cfe/trunk/test/SemaObjC/protocol-archane.m<br><br>Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td?rev=176303&r1=176302&r2=176303&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td?rev=176303&r1=176302&r2=176303&view=diff</a><br>==============================================================================<br>--- cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td (original)<br>+++ cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td Thu Feb 28 16:36:31 2013<br>@@ -363,7 +363,7 @@ def note_objc_container_start : Note<<br> "%select{class|protocol|category|class extension|implementation"<br> "|category implementation}0 started here">;<br>def warn_objc_protocol_qualifier_missing_id : Warning<<br>- "protocol qualifiers without 'id' is archaic">;<br>+ "property has no object type specified; defaults to qualified 'id'">;<br></div></blockquote><div><br></div><div>"property"? Your test case is a local variable. Was that supposed to be "protocol"?</div><div><br></div><br><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;">def err_objc_unknown_at : Error<"expected an Objective-C directive after '@'">;<br>def err_illegal_super_cast : Error<<br> "cannot cast 'super' (it isn't an expression)">;<br><br>Modified: cfe/trunk/test/FixIt/fixit-objc.m<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/FixIt/fixit-objc.m?rev=176303&r1=176302&r2=176303&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/FixIt/fixit-objc.m?rev=176303&r1=176302&r2=176303&view=diff</a><br>==============================================================================<br>--- cfe/trunk/test/FixIt/fixit-objc.m (original)<br>+++ cfe/trunk/test/FixIt/fixit-objc.m Thu Feb 28 16:36:31 2013<br>@@ -11,7 +11,7 @@<br>@protocol X;<br><br>void foo() {<br>- <X> *P; // expected-warning{{protocol qualifiers without 'id' is archaic}}<br>+ <X> *P; // expected-warning{{property has no object type specified; defaults to qualified 'id'}}<br>}<br><br>@class A;<br><br>Modified: cfe/trunk/test/Parser/placeholder-recovery.m<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Parser/placeholder-recovery.m?rev=176303&r1=176302&r2=176303&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Parser/placeholder-recovery.m?rev=176303&r1=176302&r2=176303&view=diff</a><br>==============================================================================<br>--- cfe/trunk/test/Parser/placeholder-recovery.m (original)<br>+++ cfe/trunk/test/Parser/placeholder-recovery.m Thu Feb 28 16:36:31 2013<br>@@ -5,7 +5,7 @@<br>// bogus 'archaic' warnings with bad location info.<br>@protocol <#protocol name#> <NSObject> // expected-error 2{{expected identifier}} \<br>// expected-error{{cannot find protocol declaration for 'NSObject'}} \<br>-// expected-warning{{protocol qualifiers without 'id'}}<br>+// expected-warning{{property has no object type specified; defaults to qualified 'id'}}<br><br><#methods#> // expected-error{{expected identifier}}<br><br><br>Modified: cfe/trunk/test/SemaObjC/protocol-archane.m<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/protocol-archane.m?rev=176303&r1=176302&r2=176303&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/protocol-archane.m?rev=176303&r1=176302&r2=176303&view=diff</a><br>==============================================================================<br>--- cfe/trunk/test/SemaObjC/protocol-archane.m (original)<br>+++ cfe/trunk/test/SemaObjC/protocol-archane.m Thu Feb 28 16:36:31 2013<br>@@ -8,9 +8,9 @@<br>void bar();<br>void foo(id x) {<br> bar((short<SomeProtocol>)x); // expected-error {{expected ')'}} expected-note {{to match this '('}}<br>- bar((<SomeProtocol>)x); // expected-warning {{protocol qualifiers without 'id' is archaic}}<br>+ bar((<SomeProtocol>)x); // expected-warning {{property has no object type specified; defaults to qualified 'id'}}<br><br>- [(<SomeProtocol>)x bar]; // expected-warning {{protocol qualifiers without 'id' is archaic}}<br>+ [(<SomeProtocol>)x bar]; // expected-warning {{property has no object type specified; defaults to qualified 'id'}}<br>}<br><br>@protocol MyProtocol<br>@@ -37,6 +37,6 @@ Class <SomeProtocol> UnfortunateGCCExten<br>@protocol Broken @end<br>@interface Crash @end<br>@implementation Crash<br>-- (void)crashWith:(<Broken>)a { // expected-warning {{protocol qualifiers without 'id' is archaic}}<br>+- (void)crashWith:(<Broken>)a { // expected-warning {{property has no object type specified; defaults to qualified 'id'}}<br>}<br>@end<br><br><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></div></blockquote></div><br></body></html>