<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Feb 22, 2013 at 10:39 PM, Matt Beaumont-Gay <span dir="ltr"><<a href="mailto:matthewbg@google.com" target="_blank">matthewbg@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Sorry for the necro-review-thread nitpicking...<br>
<div class="im"><br>
On Fri, Feb 1, 2013 at 4:36 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br>
> Author: dblaikie<br>
> Date: Fri Feb  1 18:36:58 2013<br>
> New Revision: 174248<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=174248&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=174248&view=rev</a><br>
> Log:<br>
> Sentenc-ify comment added in r174206.<br>
><br>
> Based on post-commit review by Paul Robinson.<br>
><br>
> Modified:<br>
>     cfe/trunk/lib/CodeGen/CodeGenFunction.cpp<br>
><br>
> Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenFunction.cpp?rev=174248&r1=174247&r2=174248&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenFunction.cpp?rev=174248&r1=174247&r2=174248&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/lib/CodeGen/CodeGenFunction.cpp (original)<br>
> +++ cfe/trunk/lib/CodeGen/CodeGenFunction.cpp Fri Feb  1 18:36:58 2013<br>
> @@ -144,8 +144,8 @@ void CodeGenFunction::EmitReturnBlock()<br>
>      if (BI && BI->isUnconditional() &&<br>
>          BI->getSuccessor(0) == ReturnBlock.getBlock()) {<br>
>        // Reset insertion point, including debug location, and delete the branch.<br>
> -      // this is really subtle & only works because the next change in location<br>
> -      // will hit the caching in CGDebugInfo::EmitLocation & not override this<br>
> +      // This is really subtle & only works because the next change in location<br>
> +      // will hit the caching in CGDebugInfo::EmitLocation & not override this.<br>
<br>
</div>I'd generally prefer "and" to "&" in prose.<br></blockquote><div><br></div><div style>Fair enough - weird habit I should probably kick. Fixed in r175969.<br><br>- David</div><div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
>        Builder.SetCurrentDebugLocation(BI->getDebugLoc());<br>
>        Builder.SetInsertPoint(BI->getParent());<br>
>        BI->eraseFromParent();<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div></div>