<div dir="ltr">Hi Bill,<div><br></div><div style>Thanks for the changes, we're almost there... ;)</div><div><br></div><div><a href="http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a9/builds/5339/steps/check-all/logs/Clang%20%3A%3A%20CodeGen__address-safety-attr.cpp">http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a9/builds/5339/steps/check-all/logs/Clang%20%3A%3A%20CodeGen__address-safety-attr.cpp</a><br>
</div><div><br></div><div style>cheers,</div><div>--renato<br></div><div><br></div><div style>PS: I'm trying to come up with a plan where people can test on ARM devices directly to avoid this kind of iteration, but security concerns (and my lack of white hat ability) are delaying any concrete plans to do it. I thought about something like the test page we used to have on <a href="http://llvm.org">llvm.org</a>, but on ARM. Ideas welcome.</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On 21 February 2013 19:44, Bill Wendling <span dir="ltr"><<a href="mailto:isanbard@gmail.com" target="_blank">isanbard@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: void<br>
Date: Thu Feb 21 13:44:18 2013<br>
New Revision: 175784<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=175784&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=175784&view=rev</a><br>
Log:<br>
Try to get buildbots to pass these tests.<br>
<br>
Modified:<br>
    cfe/trunk/test/CXX/special/class.dtor/p3-0x.cpp<br>
    cfe/trunk/test/CodeGen/address-safety-attr.cpp<br>
<br>
Modified: cfe/trunk/test/CXX/special/class.dtor/p3-0x.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CXX/special/class.dtor/p3-0x.cpp?rev=175784&r1=175783&r2=175784&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CXX/special/class.dtor/p3-0x.cpp?rev=175784&r1=175783&r2=175784&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/test/CXX/special/class.dtor/p3-0x.cpp (original)<br>
+++ cfe/trunk/test/CXX/special/class.dtor/p3-0x.cpp Thu Feb 21 13:44:18 2013<br>
@@ -176,4 +176,4 @@ struct TVC : VX<br>
 template <typename T><br>
 TVC<T>::~TVC() {}<br>
<br>
-// CHECK: attributes [[ATTRGRP]] = { nounwind "target-features"={{.*}} }<br>
+// CHECK: attributes [[ATTRGRP]] = { nounwind{{.*}} }<br>
<br>
Modified: cfe/trunk/test/CodeGen/address-safety-attr.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/address-safety-attr.cpp?rev=175784&r1=175783&r2=175784&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/address-safety-attr.cpp?rev=175784&r1=175783&r2=175784&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/test/CodeGen/address-safety-attr.cpp (original)<br>
+++ cfe/trunk/test/CodeGen/address-safety-attr.cpp Thu Feb 21 13:44:18 2013<br>
@@ -47,12 +47,15 @@ int force_instance = TemplateAddressSafe<br>
 // Check that __cxx_global_var_init* get the address_safety attribute.<br>
 int global1 = 0;<br>
 int global2 = *(int*)((char*)&global1+1);<br>
-// WITHOUT: @__cxx_global_var_init{{.*}}#1<br>
-// BL: @__cxx_global_var_init{{.*}}#1<br>
-// ASAN: @__cxx_global_var_init{{.*}}#2<br>
+// WITHOUT: @__cxx_global_var_init{{.*}}#[[GVI:[0-9]+]]<br>
+// BL: @__cxx_global_var_init{{.*}}#[[GVI:[0-9]+]]<br>
+// ASAN: @__cxx_global_var_init{{.*}}#[[GVI:[0-9]+]]<br>
<br>
-// WITHOUT: attributes #[[NOATTR]] = { nounwind "target-features"={{.*}} }<br>
-// BL: attributes #[[NOATTR]] = { nounwind "target-features"={{.*}} }<br>
+// WITHOUT: attributes #[[NOATTR]] = { nounwind{{.*}} }<br>
+// WITHOUT: attributes #[[GVI]] = { nounwind{{.*}} }<br>
+// BL: attributes #[[NOATTR]] = { nounwind{{.*}} }<br>
+// BL: attributes #[[GVI]] = { nounwind{{.*}} }<br>
<br>
-// ASAN: attributes #[[NOATTR]] = { nounwind "target-features"={{.*}} }<br>
-// ASAN: attributes #[[WITH]] = { address_safety nounwind "target-features"={{.*}} }<br>
+// ASAN: attributes #[[NOATTR]] = { nounwind{{.*}} }<br>
+// ASAN: attributes #[[WITH]] = { address_safety nounwind{{.*}} }<br>
+// ASAN: attributes #[[GVI]] = { address_safety nounwind{{.*}} }<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>