<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">iOS wants to default to a CPU setting of cortex-a8 when compiling for an arch of v7. That implies NEON. I don't know if this particular bit of code is necessary to make that happen properly. I suggest experimenting and digging a bit to see how that works.<div><br></div><div>In any case, changing the default of whether NEON is available for armv7 when compiling for iOS is very much the wrong thing to do.</div><div><br></div><div>-Jim<br><div><br><div><div>On Feb 19, 2013, at 1:53 PM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">At the very least I agree that's the wrong place to be doing that. Or it should be conditionalized on OS if the ios people want to do that.<div><br></div><div>-eric<br><br><div class="gmail_quote">On Tue, Feb 19, 2013 at 1:50 PM, Saleem Abdulrasool <span dir="ltr"><<a href="mailto:compnerd@compnerd.org" target="_blank">compnerd@compnerd.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi echristo, grosbach,<br>
<br>
ARMv7 chipsets usually are paired with a NEON FPU. However, this is not<br>
required (e.g. tegra2). Rather than always forcing NEON as the FPU for ARMv7<br>
chips, honour the -mfpu flag, which already is being done. If -mfpu is not<br>
specified, then let the default FPU remain selected (VFP).<br>
<br>
Signed-off-by: Saleem Abdulrasool <<a href="mailto:compnerd@compnerd.org">compnerd@compnerd.org</a>><br>
<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D425" target="_blank">http://llvm-reviews.chandlerc.com/D425</a><br>
<br>
Files:<br>
lib/Driver/Tools.cpp<br>
<br>
Index: lib/Driver/Tools.cpp<br>
===================================================================<br>
--- lib/Driver/Tools.cpp<br>
+++ lib/Driver/Tools.cpp<br>
@@ -5494,10 +5494,6 @@<br>
CmdArgs.push_back("-mppc64");<br>
CmdArgs.push_back("-many");<br>
} else if (getToolChain().getArch() == llvm::Triple::arm) {<br>
- StringRef MArch = getToolChain().getArchName();<br>
- if (MArch == "armv7" || MArch == "armv7a" || MArch == "armv7-a")<br>
- CmdArgs.push_back("-mfpu=neon");<br>
-<br>
StringRef ARMFloatABI = getARMFloatABI(getToolChain().getDriver(), Args,<br>
getToolChain().getTriple());<br>
CmdArgs.push_back(Args.MakeArgString("-mfloat-abi=" + ARMFloatABI));<br>
</blockquote></div><br></div>
</blockquote></div><br></div></div></body></html>