<p dir="ltr"><br>
On Feb 18, 2013 6:33 PM, "Aaron Ballman" <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> wrote:<br>
><br>
> Author: aaronballman<br>
> Date: Mon Feb 18 20:32:05 2013<br>
> New Revision: 175483<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=175483&view=rev">http://llvm.org/viewvc/llvm-project?rev=175483&view=rev</a><br>
> Log:<br>
> Fixing a typo where FixIts was accidentally self-assigning instead of assigning in the parameter Fixits. This fixes several failed assertions with MSVC debug builds.</p>
<p dir="ltr">I would've thought this bug would manifest much more visibly than just some asserts under MSvc. Given that we now can see the root cause, does anyone want to have a go at figuring out what test cases were missed when this big was originally committed? I imagine failing to copy a parameter into a member would be highly visible.</p>

<p dir="ltr">><br>
> Modified:<br>
>     cfe/trunk/lib/Basic/Diagnostic.cpp<br>
><br>
> Modified: cfe/trunk/lib/Basic/Diagnostic.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Diagnostic.cpp?rev=175483&r1=175482&r2=175483&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Diagnostic.cpp?rev=175483&r1=175482&r2=175483&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/lib/Basic/Diagnostic.cpp (original)<br>
> +++ cfe/trunk/lib/Basic/Diagnostic.cpp Mon Feb 18 20:32:05 2013<br>
> @@ -959,7 +959,7 @@ StoredDiagnostic::StoredDiagnostic(Diagn<br>
>    : ID(ID), Level(Level), Loc(Loc), Message(Message)<br>
>  {<br>
>    this->Ranges.assign(Ranges.begin(), Ranges.end());<br>
> -  this->FixIts.assign(FixIts.begin(), FixIts.end());<br>
> +  this->FixIts.assign(Fixits.begin(), Fixits.end());<br>
>  }<br>
><br>
>  StoredDiagnostic::~StoredDiagnostic() { }<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</p>