<div dir="ltr">On Wed, Feb 6, 2013 at 12:55 PM, Dmitri Gribenko <span dir="ltr"><<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5">On Wed, Feb 6, 2013 at 11:42 AM, Manuel Klimek <<a href="mailto:klimek@google.com">klimek@google.com</a>> wrote:<br>

> Author: klimek<br>
> Date: Wed Feb  6 03:42:05 2013<br>
> New Revision: 174497<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=174497&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=174497&view=rev</a><br>
> Log:<br>
> Kick JSON output for XML output.<br>
><br>
> Apparently the owners of the tools we want to integrate with (eclipse in<br>
> this case) don't have JSON parsers.<br>
><br>
> The output now is:<br>
> <replacements><br>
> <replacement offset='2' length='3'>  </replacement><br>
> ...<br>
> </replacements><br>
><br>
> Kicking JSON for now - it's easy enough to get back in when we need it.<br>
><br>
> FIXME: once we find this useful enough, we might want to add it as<br>
> free-standing functions to tooling.<br>
><br>
> Modified:<br>
>     clang-tools-extra/trunk/clang-format/ClangFormat.cpp<br>
><br>
> Modified: clang-tools-extra/trunk/clang-format/ClangFormat.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-format/ClangFormat.cpp?rev=174497&r1=174496&r2=174497&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-format/ClangFormat.cpp?rev=174497&r1=174496&r2=174497&view=diff</a><br>

> ==============================================================================<br>
> --- clang-tools-extra/trunk/clang-format/ClangFormat.cpp (original)<br>
> +++ clang-tools-extra/trunk/clang-format/ClangFormat.cpp Wed Feb  6 03:42:05 2013<br>
> @@ -38,8 +38,8 @@ static cl::opt<std::string> Style(<br>
>  static cl::opt<bool> Inplace("i",<br>
>                               cl::desc("Inplace edit <file>, if specified."));<br>
><br>
> -static cl::opt<bool> OutputReplacements(<br>
> -    "output-replacements", cl::desc("Output replacements as JSON."));<br>
> +static cl::opt<bool> OutputXML(<br>
> +    "output-replacements-xml", cl::desc("Output replacements as XML."));<br>
><br>
>  // FIXME: Remove this when styles are configurable through files.<br>
>  static cl::opt<bool> InvertPointerBinding(<br>
> @@ -107,22 +107,17 @@ static void format() {<br>
>      Ranges.push_back(CharSourceRange::getCharRange(Start, End));<br>
>    }<br>
>    tooling::Replacements Replaces = reformat(getStyle(), Lex, Sources, Ranges);<br>
> -  if (OutputReplacements) {<br>
> -    llvm::outs() << "[\n";<br>
> +  if (OutputXML) {<br>
> +    llvm::outs() << "<?xml version='1.0'?>\n<replacements>\n";<br>
>      for (tooling::Replacements::const_iterator I = Replaces.begin(),<br>
>                                                 E = Replaces.end();<br>
>           I != E; ++I) {<br>
> -      if (I != Replaces.begin()) {<br>
> -        llvm::outs() << ",\n";<br>
> -      }<br>
> -      llvm::outs() << "  {\n"<br>
> -                   << "    \"offset\": " << I->getOffset() << ",\n"<br>
> -                   << "    \"length\": " << I->getLength() << ",\n"<br>
> -                   << "    \"replacement_text\": \"" << I->getReplacementText()<br>
> -                   << "\"\n"<br>
> -                   << "  }";<br>
> +      llvm::outs() << "<replacement "<br>
> +                   << "offset='" << I->getOffset() << "' "<br>
> +                   << "length='" << I->getLength() << "'>"<br>
> +                   << I->getReplacementText() << "</replacement>\n";<br>
<br>
</div></div>You need xml:space="preserve" or the whitespace may be collapsed by<br>
xml processing tools.<br></blockquote><div><br></div><div style>Thanks! From STFW'ing I understand that I only need to set it on the toplevel element (replacements), right?</div><div style>If so, fixed in r174502.</div>
<div style><br></div><div style>Cheers,</div><div style>/Manuel</div><div style><br></div><div style> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

<span class=""><font color="#888888"><br>
Dmitri<br>
<br>
--<br>
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if<br>
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com">gribozavr@gmail.com</a>>*/<br>
</font></span></blockquote></div><br></div></div>