<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Feb 5, 2013 at 2:13 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Tue, Feb 5, 2013 at 2:07 PM, Daniel Dunbar <<a href="mailto:daniel@zuster.org">daniel@zuster.org</a>> wrote:<br>
> On Tue, Feb 5, 2013 at 2:01 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br>
>><br>
>> On Tue, Feb 5, 2013 at 1:43 PM, Daniel Dunbar <<a href="mailto:daniel@zuster.org">daniel@zuster.org</a>> wrote:<br>
>> > Author: ddunbar<br>
>> > Date: Tue Feb 5 15:43:30 2013<br>
>> > New Revision: 174443<br>
>> ><br>
>> > URL: <a href="http://llvm.org/viewvc/llvm-project?rev=174443&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=174443&view=rev</a><br>
>> > Log:<br>
>> > [tests] Add an available feature that combines the triple and<br>
>> > use_system_lib.<br>
>> ><br>
>> > - This is so that we can easily write XFAIL markers for tests that are<br>
>> > known<br>
>> > to fail with versions of libc++ as were shipped with a particular<br>
>> > triple.<br>
>><br>
>> Seems a bit strange to be running the current/ToT test suite against<br>
>> some prior release (& we don't maintain such functionality/xfails in<br>
>> the Clang test suite, for example) - what's the particular use case<br>
>> that differs from our other regression test suites?<br>
><br>
><br>
> It's not strange, libc++ at least on Darwin ships as a dynamic library, so<br>
> it is important and valuable to test against the shipped library (to catch<br>
> unintended ABI changes, for example).<br>
<br>
</div>OK, so it's not the test suite run against the already-shipped libc++,<br>
it's the test suite run against the ToT libc++ headers against the<br>
already-shipped shared library.<br></blockquote><div><br></div><div style>Right.</div><div style> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I suppose there's no real equivalent in the Clang & LLVM regression<br>
suites since they don't produce executables that are run as part of<br>
the suite (so if compiler-rt or other things change in incompatible<br>
ways that suite wouldn't detect it (& I assume we don't try to be<br>
backwards compatible there anyway)). Fair enough.<br></blockquote><div><br></div><div style>Right. We actually have a need for a similar kind of testing with clang + compiler-rt and deployment targets on OS X, where we want to make sure we can build a binary on 10.7 say and specify it should be deployable back to 10.5, and then have a way to check that. Unfortunately, the only good way of "checking that" is to ship it over to a 10.6 or 10.5 system and run it, which we don't have real support for.</div>
<div style><br></div><div style> - Daniel</div><div style> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888"><br>
- David<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
><br>
> - Daniel<br>
><br>
>><br>
>><br>
>> ><br>
>> > Modified:<br>
>> > libcxx/trunk/test/lit.cfg<br>
>> ><br>
>> > Modified: libcxx/trunk/test/lit.cfg<br>
>> > URL:<br>
>> > <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/lit.cfg?rev=174443&r1=174442&r2=174443&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/lit.cfg?rev=174443&r1=174442&r2=174443&view=diff</a><br>
>> ><br>
>> > ==============================================================================<br>
>> > --- libcxx/trunk/test/lit.cfg (original)<br>
>> > +++ libcxx/trunk/test/lit.cfg Tue Feb 5 15:43:30 2013<br>
>> > @@ -278,3 +278,11 @@ config.test_format = LibcxxTestFormat(<br>
>> ><br>
>> > config.target_triple = lit.params.get(<br>
>> > 'target_triple', 'unknown-unknown-unknown')<br>
>> > +<br>
>> > +# Write an "available feature" that combines the triple when<br>
>> > use_system_lib is<br>
>> > +# enabled. This is so that we can easily write XFAIL markers for tests<br>
>> > that are<br>
>> > +# known to fail with versions of libc++ as were shipped with a<br>
>> > particular<br>
>> > +# triple.<br>
>> > +if use_system_lib:<br>
>> > + config.available_features.add('with_system_lib=%s' % (<br>
>> > + config.target_triple,))<br>
>> ><br>
>> ><br>
>> > _______________________________________________<br>
>> > cfe-commits mailing list<br>
>> > <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
>> > <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
><br>
><br>
</div></div></blockquote></div><br></div></div>