<div dir="ltr">LGTM</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jan 31, 2013 at 9:56 AM, Edwin Vane <span dir="ltr"><<a href="mailto:edwin.vane@intel.com" target="_blank">edwin.vane@intel.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> - Adding check_cxx_compiler_flag test.<br>
<br>
Hi gribozavr, dblaikie,<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D358" target="_blank">http://llvm-reviews.chandlerc.com/D358</a><br>
<br>
CHANGE SINCE LAST DIFF<br>
<a href="http://llvm-reviews.chandlerc.com/D358?vs=846&id=848#toc" target="_blank">http://llvm-reviews.chandlerc.com/D358?vs=846&id=848#toc</a><br>
<div class="im"><br>
Files:<br>
cmake/modules/HandleLLVMOptions.cmake<br>
<br>
Index: cmake/modules/HandleLLVMOptions.cmake<br>
===================================================================<br>
--- cmake/modules/HandleLLVMOptions.cmake<br>
+++ cmake/modules/HandleLLVMOptions.cmake<br>
</div>@@ -178,6 +178,19 @@<br>
<div class="im"> elseif( LLVM_COMPILER_IS_GCC_COMPATIBLE )<br>
if (LLVM_ENABLE_WARNINGS)<br>
add_llvm_definitions( -Wall -W -Wno-unused-parameter -Wwrite-strings )<br>
+<br>
+ # Turn off missing field initializer warnings for gcc to avoid noise from<br>
+ # false positives with empty {}. Turn them on otherwise (they're off by<br>
+ # default for clang).<br>
</div>+ check_cxx_compiler_flag("-Wmissing-field-initializers" CXX_SUPPORTS_MISSING_FIELD_INITIALIZERS_FLAG)<br>
+ if (CXX_SUPPORTS_MISSING_FIELD_INITIALIZERS_FLAG)<br>
<div class="im">+ if (CMAKE_COMPILER_IS_GNUCXX)<br>
+ add_llvm_definitions( -Wno-missing-field-initializers )<br>
+ else()<br>
+ add_llvm_definitions( -Wmissing-field-initializers )<br>
+ endif()<br>
</div>+ endif()<br>
<div class="HOEnZb"><div class="h5">+<br>
if (LLVM_ENABLE_PEDANTIC)<br>
add_llvm_definitions( -pedantic -Wno-long-long )<br>
endif (LLVM_ENABLE_PEDANTIC)<br>
</div></div><br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>