<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Overall, this patch looks ok to me.<div><br></div><div>I'm not familiar enough with the changes in lib/SemaOverload though to know if that is correct. Do you have a test case that is covering that case?</div><div><br></div><div>Thanks,</div><div>Tanya</div><div><br><div><div>On Jan 28, 2013, at 5:54 AM, "Benyei, Guy" <<a href="mailto:guy.benyei@intel.com">guy.benyei@intel.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="2050" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1"><p class="MsoNormal"><span style="color:#1F497D">Hi Tanya,<o:p></o:p></span></p><p class="MsoNormal"><span style="color:#1F497D">Here is the sampler part.<o:p></o:p></span></p><p class="MsoNormal"><span style="color:#1F497D"> </span></p><p class="MsoNormal"><span style="color:#1F497D">Please review.<o:p></o:p></span></p><p class="MsoNormal"><span style="color:#1F497D"> </span></p>
<div><p class="MsoNormal"><span style="color:#1F497D"><span><image001.png></span><o:p></o:p></span></p>
</div><p class="MsoNormal"><span style="color:#1F497D"> </span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"><p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Tanya Lattner [<a href="mailto:lattner@apple.com">mailto:lattner@apple.com</a>]
<br>
<b>Sent:</b> Saturday, January 26, 2013 02:19<br>
<b>To:</b> Benyei, Guy<br>
<b>Cc:</b> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<b>Subject:</b> Re: [cfe-commits] [PATCH]OpenCL samplers<o:p></o:p></span></p>
</div>
</div><p class="MsoNormal"><o:p> </o:p></p><p class="MsoNormal">Guy, <o:p></o:p></p>
<div><p class="MsoNormal"><o:p> </o:p></p>
</div>
<div><p class="MsoNormal">I would break this out into separate patches. One for the sampler type, one for restriction checking, and the fix for event_t.<o:p></o:p></p>
</div>
<div><p class="MsoNormal"><o:p> </o:p></p>
</div>
<div><p class="MsoNormal">-Tanya<o:p></o:p></p>
</div>
<div><p class="MsoNormal"><o:p> </o:p></p>
<div>
<div><p class="MsoNormal">On Jan 24, 2013, at 12:37 PM, "Benyei, Guy" <<a href="mailto:guy.benyei@intel.com">guy.benyei@intel.com</a>> wrote:<o:p></o:p></p>
</div><p class="MsoNormal"><br>
<br>
<o:p></o:p></p>
<div><p class="MsoNormal">Hi all,<o:p></o:p></p><p class="MsoNormal">Attached a patch that implements the OpenCL sampler_t type in Clang. The sampler_t type is represented by the i32 LLVM type.<o:p></o:p></p><p class="MsoNormal">Added also some restriction checking for images and samplers, and a fix for the event_t implementation that enables using zero events with function overloading.<o:p></o:p></p><p class="MsoNormal"> <o:p></o:p></p><p class="MsoNormal">Please review<o:p></o:p></p><p class="MsoNormal"> <o:p></o:p></p><p class="MsoNormal"> Thanks<o:p></o:p></p><p class="MsoNormal"> Guy Benyei<o:p></o:p></p><p class="MsoNormal"> <o:p></o:p></p><p class="MsoNormal"><image001.png><o:p></o:p></p><p class="MsoNormal"> <o:p></o:p></p>
</div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif""><opencl_samplers.patch><o:p></o:p></span></p><p>---------------------------------------------------------------------<br>
Intel Israel (74) Limited<o:p></o:p></p><p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.<o:p></o:p></p><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><o:p></o:p></span></p>
</div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif""> </span></p>
</div>
</div>
</div>
<span><opencl_samplers2.patch></span><p>---------------------------------------------------------------------<br>
Intel Israel (74) Limited</p><p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</p></blockquote></div><br></div></body></html>