<br><br><div class="gmail_quote">On Sat, Jan 26, 2013 at 4:26 AM, Richard Trieu <span dir="ltr"><<a href="mailto:rtrieu@google.com" target="_blank">rtrieu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">One screenshot of how indenting looks with color.<div>One text file with escape characters for viewing the colors on your terminal.</div><div><br></div><div>Bikeshed away.</div></div><div class="HOEnZb"><div class="h5">
<div class="gmail_extra">
<br><br></div></div></div></blockquote><div>This looks really nice! The indent are clean, picking out the variable names is easy, the structure is clear. I am looking forward to using this on real code.<br><br>-- Matthieu<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><div class="gmail_quote">On Fri, Jan 25, 2013 at 7:23 PM, Richard Trieu <span dir="ltr"><<a href="mailto:rtrieu@google.com" target="_blank">rtrieu@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This merges the color printing with indenting to show the final product. This revision has no parens, and no extra leading space.<br>
<br>
Regular blue is the color used for the tree information which contrasts to the bolded colors used for Stmts, Decls, Attrs, and Comments. The bold nodes will stand out better while the light coloring of the tree hints at the structure without visually interfering.<br>
<div><br>
<a href="http://llvm-reviews.chandlerc.com/D281" target="_blank">http://llvm-reviews.chandlerc.com/D281</a><br>
<br>
CHANGE SINCE LAST DIFF<br>
</div> <a href="http://llvm-reviews.chandlerc.com/D281?vs=761&id=771#toc" target="_blank">http://llvm-reviews.chandlerc.com/D281?vs=761&id=771#toc</a><br>
<br>
Files:<br>
lib/AST/ASTDumper.cpp<br>
test/Misc/ast-dump-wchar.cpp<br>
test/Misc/ast-dump-color.cpp<br>
test/Misc/ast-dump-comment.cpp<br>
test/Misc/ast-dump-decl.c<br>
test/Misc/ast-dump-attr.cpp<br>
test/Misc/ast-dump-stmt.c<br>
test/CodeGen/bitfield-2.c<br>
test/Tooling/clang-check-ast-dump.cpp<br>
test/Sema/implicit-cast-dump.c<br>
utils/TableGen/ClangAttrEmitter.cpp<br>
</blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br>