<div dir="ltr">Thanks!<div style><br></div><div style>--renato</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 22 January 2013 13:34, Alexander Potapenko <span dir="ltr"><<a href="mailto:glider@google.com" target="_blank">glider@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Renato,<br>
I've fixed the test in my next commit:<br>
<a href="http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a9/builds/4550" target="_blank">http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a9/builds/4550</a><br>
<div class="HOEnZb"><div class="h5"><br>
On Tue, Jan 22, 2013 at 5:33 PM, Renato Golin Linaro<br>
<<a href="mailto:renato.golin@linaro.org">renato.golin@linaro.org</a>> wrote:<br>
> Hi Alexander,<br>
><br>
> This commit broke the test: Driver/darwin-sanitizer-ld.c on ARM buildbots:<br>
><br>
> <a href="http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a9/builds/4549" target="_blank">http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a9/builds/4549</a><br>
><br>
> Looks like the name of the lib must also be updated...<br>
><br>
> cheers,<br>
> --renato<br>
><br>
><br>
><br>
> On 22 January 2013 09:16, Alexander Potapenko <<a href="mailto:glider@google.com">glider@google.com</a>> wrote:<br>
>><br>
>> Author: glider<br>
>> Date: Tue Jan 22 03:16:03 2013<br>
>> New Revision: 173135<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=173135&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=173135&view=rev</a><br>
>> Log:<br>
>> [ASan] Link with the dynamic runtime on OS X<br>
>> This patch changes the behavior of the -fsanitize=address flag, making it<br>
>> use the dynamic runtime library (libclang_rt.asan_osx_dynamic.dylib) instead<br>
>> of the static one. It also drops the CoreFoundation dependency, since the<br>
>> dynamic runtime doesn't need it.<br>
>><br>
>><br>
>> Modified:<br>
>>     cfe/trunk/lib/Driver/ToolChains.cpp<br>
>><br>
>> Modified: cfe/trunk/lib/Driver/ToolChains.cpp<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=173135&r1=173134&r2=173135&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=173135&r1=173134&r2=173135&view=diff</a><br>

>><br>
>> ==============================================================================<br>
>> --- cfe/trunk/lib/Driver/ToolChains.cpp (original)<br>
>> +++ cfe/trunk/lib/Driver/ToolChains.cpp Tue Jan 22 03:16:03 2013<br>
>> @@ -339,12 +339,10 @@<br>
>>        getDriver().Diag(diag::err_drv_clang_unsupported_per_platform)<br>
>>          << "-fsanitize=address";<br>
>>      } else {<br>
>> -      AddLinkRuntimeLib(Args, CmdArgs, "libclang_rt.asan_osx.a", true);<br>
>> +      AddLinkRuntimeLib(Args, CmdArgs,<br>
>> "libclang_rt.asan_osx_dynamic.dylib", true);<br>
>><br>
>> -      // The ASAN runtime library requires C++ and CoreFoundation.<br>
>> +      // The ASAN runtime library requires C++.<br>
>>        AddCXXStdlibLibArgs(Args, CmdArgs);<br>
>> -      CmdArgs.push_back("-framework");<br>
>> -      CmdArgs.push_back("CoreFoundation");<br>
>>      }<br>
>>    }<br>
>><br>
>><br>
>><br>
>> _______________________________________________<br>
>> cfe-commits mailing list<br>
>> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
><br>
><br>
<br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Alexander Potapenko<br>
Software Engineer<br>
Google Moscow<br>
</font></span></blockquote></div><br></div>