<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jan 18, 2013, at 18:55 , Anna Zaks <<a href="mailto:ganna@apple.com">ganna@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jan 18, 2013, at 6:43 PM, Jordan Rose <<a href="mailto:jordan_rose@apple.com">jordan_rose@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><blockquote type="cite" style="font-size: 15px; "><blockquote type="cite"></blockquote></blockquote></div></blockquote><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><blockquote type="cite" style="font-size: 15px; "><blockquote type="cite"></blockquote></blockquote></div></blockquote></div></div></blockquote><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><blockquote type="cite"><blockquote type="cite"><span style="font-size: 12px; ">- if (Call && doesNotFreeMemory(Call, State))</span></blockquote></blockquote></div></div></div><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><blockquote type="cite" style="font-size: 15px; "></blockquote><div><span style="font-size: 15px; "><div><div style="font-size: 12px; ">+ if ((Kind == PSK_DirectEscapeOnCall ||</div><div style="font-size: 12px; ">+ Kind == PSK_IndirectEscapeOnCall) &&</div><div style="font-size: 12px; ">+ doesNotFreeMemory(Call, State)) {</div></div><div style="font-size: 12px; "><br></div><div style="font-size: 12px; ">This is not correct. Before, this branch was only taken if the Kind is PSK_DirectEscapeOnCall. Indirect escapes can still possibly free memory (although it's unlikely).</div><div style="font-size: 12px; "><br></div></span></div></div></blockquote><div><br></div><div>Jordan,</div><div><br></div><div>I think the condition is correct. In fact, this is the whole point of this commit.</div><div>For example, previously, we would assume that a call to foo_that_does_not_free_memory(p+1), could free memory.</div><div><br></div><div>Branden, can you add a test case that shows this? I know the test cases in the second patch rely on this, but a self contained example would make the change explicit. (Ex: you could call a function from a system header and pass it p+1.)</div></div></div></blockquote><br></div><div>...ah. Okay, right. Carry on.</div><br></body></html>