On Thu, Jan 10, 2013 at 9:40 PM, Ryan Molden <span dir="ltr"><<a href="mailto:ryanmolden@gmail.com" target="_blank">ryanmolden@gmail.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im"><div class="gmail_quote"><blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote"><div><div> </div>
</div>
Please rebase the patch against the latest trunk -- in order to<br>
approximately match GCC, we now return false from the __has_trivial_*<br>
and __has_nothrow_* builtins if the class has both a trivial such<br>
special member and a nontrivial one.<br>
<br>
Ultimately, I wonder if we should just ignore GCC's specification for<br>
how these builtins should work, and instead implement the semantics of<br>
the corresponding C++11 type traits here. It's actually not possible<br>
to implement the traits correctly from the defined semantics of the<br>
traits which libstdc++ and MSVC's STL use.<br>
</blockquote></div></div><div><br>Attached is a patch against trunk, I believe I picked up / merged your recent changes properly, let me know if I mucked it up or misunderstood you (I just merged your changes I didn't augment the code I had in there from before your changes).<br>
</div><div>I am all for matching the standard regardless of what GCC/MSVC decide(d) to do here, I assume if they are non-standard at the moment they will soon get in line.</div><div><br>Earlier (last week?) I sent a mail about seeing some build issues with macho_dump.I don't believe they are caused by my changes, clang still builds and the tests still pass, but it is unclear what the failures mean or how to investigate them, which is why I hadn't yet sent the patch.</div>
<span class="HOEnZb"><font color="#888888">
<div> </div><div>Ryan</div>
</font></span></blockquote></div><br><div>Anything else I need to do here? I haven't seen a check-in mail, then again there have been hundreds of mails so perhaps I missed it, or there is some formal process to go through to request submission?</div>
<div><br></div><div>Ryan</div>