<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I tend to agree with Stefanus. If we were to make the use of nullptr a fixit only it would mean a two-step process for anybody migrating their code base with
the cpp11-migrate tool: use cpp11-migrate to get everything but nullptr and then use clang in fixit mode to get nullptr. A fixit is definitely useful but having the same functionality in cpp11-migrate is also useful.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> cfe-commits-bounces@cs.uiuc.edu [mailto:cfe-commits-bounces@cs.uiuc.edu]
<b>On Behalf Of </b>Stefanus Du Toit<br>
<b>Sent:</b> Monday, January 14, 2013 3:11 PM<br>
<b>To:</b> David Blaikie<br>
<b>Cc:</b> reviews+D295+public+6744ee1860a6976b@llvm-reviews.chandlerc.com; llvm cfe; Siraj, Tareq A<br>
<b>Subject:</b> Re: [cfe-commits] [PATCH] Added use-nullptr transform into cpp11-migrate tool<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">On Monday, January 14, 2013, David Blaikie wrote:<o:p></o:p></p>
<p class="MsoNormal">On Mon, Jan 14, 2013 at 8:50 AM, Tareq A. Siraj <<a href="javascript:;">tareq.a.siraj@intel.com</a>> wrote:<br>
> This transform converts the usage of null pointer constants (e.g. NULL, 0,<br>
> etc.) in legacy C++ code and converts them to use the new C++11 nullptr<br>
> keyword.<br>
<br>
There are probably good reasons not to do this, but I'm still curious:<br>
<br>
Why not just build this in as a warning in clang with a FixIt? (&, if<br>
necessary, have a Clang Tool designed for applying a particular fixit<br>
to a codebase) GCC 4.8 already intends to have a<br>
-Wzero-as-null-pointer warning which we could match.<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">I think it makes sense to do this in both places. Having it in the rewriter tool is sensible so it can be applied along with other C++11 transformations. The warning/fixit also makes sense. The core of this can probably be reused and live
in Clang eventually, but start off in the tool.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Stefanus<o:p></o:p></p>
</div>
</div>
</body>
</html>