<div dir="ltr"><div class="gmail_default" style>On Sat, Jan 12, 2013 at 5:01 AM, Matthieu Monrocq <span dir="ltr"><<a href="mailto:matthieu.monrocq@gmail.com" target="_blank">matthieu.monrocq@gmail.com</a>></span> wrote:<br>
</div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br><br><div class="gmail_quote"><div><div class="h5">
On Sat, Jan 12, 2013 at 1:31 AM, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div class="h5">
<br>
<br>
================<br>
Comment at: lib/AST/ASTDumper.cpp:36-76<br>
@@ +35,43 @@<br>
+ // Decl kind names (VarDecl, FunctionDecl, etc)<br>
+ static const raw_ostream::Colors declKindNameColor = raw_ostream::GREEN;<br>
+ static const bool declKindNameBold = true;<br>
+ // Attr names (CleanupAttr, GuardedByAttr, etc)<br>
+ static const raw_ostream::Colors attrColor = raw_ostream::BLUE;<br>
+ static const bool attrBold = true;<br>
+ // Statement names (DeclStmt, ImplicitCastExpr, etc)<br>
+ static const raw_ostream::Colors stmtColor = raw_ostream::MAGENTA;<br>
+ static const bool stmtBold = true;<br>
+<br>
+ // Type names (int, float, etc, plus user defined types)<br>
+ static const raw_ostream::Colors typeColor = raw_ostream::GREEN;<br>
+ static const bool typeBold = false;<br>
+<br>
+ // Pointer address<br>
+ static const raw_ostream::Colors addressColor = raw_ostream::YELLOW;<br>
+ static const bool addressBold = false;<br>
+ // Source locations<br>
+ static const raw_ostream::Colors locationColor = raw_ostream::YELLOW;<br>
+ static const bool locationBold = true;<br>
+<br>
+ // lvalue/xvalue<br>
+ static const raw_ostream::Colors valueKindColor = raw_ostream::CYAN;<br>
+ static const bool valueKindBold = false;<br>
+ // bitfield/objcproperty/objcsubscript/vectorcomponent<br>
+ static const raw_ostream::Colors objectKindColor = raw_ostream::CYAN;<br>
+ static const bool objectKindBold = false;<br>
+<br>
+ // Null statements<br>
+ static const raw_ostream::Colors nullColor = raw_ostream::BLUE;<br>
+ static const bool nullBold = false;<br>
+<br>
+ // CastKind from CastExpr's<br>
+ static const raw_ostream::Colors castColor = raw_ostream::RED;<br>
+ static const bool castBold = false;<br>
+<br>
+ // Value of the statement<br>
+ static const raw_ostream::Colors valueColor = raw_ostream::CYAN;<br>
+ static const bool valueBold = true;<br>
+ // Decl names<br>
+ static const raw_ostream::Colors declNameColor = raw_ostream::CYAN;<br>
+ static const bool declNameBold = true;<br>
+<br>
----------------<br>
These names should all have a leading capital letter.<br>
<br>
Maybe add a struct wrapping a Colors value and a Bold flag?<br>
<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D291" target="_blank">http://llvm-reviews.chandlerc.com/D291</a><br></div></div>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br>I will let the technical details to my better... just wanted to say that the output looks awesome with the colors, it's amazing how a little touch-up makes spotting similarly kinded elements easily.<br>
<br>If I could just make a remark, it's that I would tune up the *important* parts and tune down those who matter less: here the lines/columns in bright yellow really are "in your face", are they so important that they should be more noticeable than say... variable names ?<br>
<br>Just bikeshedding sure, but since it does not look like it'll be configurable (and what herd of options it would require...) it might be worth tuning it right.<span class="HOEnZb"><font color="#888888"><br><br>-- Matthieu<br>
</font></span></blockquote></div>To be honest, I did expect a bit of bikeshedding since there are several different things to paint, so bikeshed away.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Do you prefer no highlighting or just a different color for source locations?</div>
<div class="gmail_extra">Or maybe turning off the bold so it has the same color as the pointer address before it?</div><div class="gmail_extra">Are there some parts that you would like highlighted but aren't? And what color should they be?</div>
<div class="gmail_extra"><br></div><div class="gmail_extra" style>I also would like getting the colors correct instead of having lots of churn later.</div></div></div>