On Monday, January 14, 2013, David Blaikie wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, Jan 14, 2013 at 8:50 AM, Tareq A. Siraj <<a href="javascript:;" onclick="_e(event, 'cvml', 'tareq.a.siraj@intel.com')">tareq.a.siraj@intel.com</a>> wrote:<br>
> This transform converts the usage of null pointer constants (e.g. NULL, 0,<br>
> etc.) in legacy C++ code and converts them to use the new C++11 nullptr<br>
> keyword.<br>
<br>
There are probably good reasons not to do this, but I'm still curious:<br>
<br>
Why not just build this in as a warning in clang with a FixIt? (&, if<br>
necessary, have a Clang Tool designed for applying a particular fixit<br>
to a codebase) GCC 4.8 already intends to have a<br>
-Wzero-as-null-pointer warning which we could match.</blockquote><div><br></div><div>I think it makes sense to do this in both places. Having it in the rewriter tool is sensible so it can be applied along with other C++11 transformations. The warning/fixit also makes sense. The core of this can probably be reused and live in Clang eventually, but start off in the tool.</div>
<div><br></div><div>Stefanus<span></span></div>