<div dir="ltr"><div class="gmail_default" style>On Thu, Jan 10, 2013 at 1:11 AM, David Tweed <span dir="ltr"><<a href="mailto:david.tweed@arm.com" target="_blank" class="cremed">david.tweed@arm.com</a>></span> wrote:<br>
</div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davidtweed<br>
Date: Thu Jan 10 03:11:33 2013<br>
New Revision: 172047<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=172047&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=172047&view=rev</a><br>
Log:<br>
Testing with a full OpenCL compiler (based on clang) reveals r71734 missed<br>
difference between type widths of a vector and the width of one of its elements<br>
in the case of vector shifts. Use correct witdth in the vector case.<br></blockquote><div><br></div><div style>This still needs a regression test case.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<br>
Modified:<br>
    cfe/trunk/lib/CodeGen/CGExprScalar.cpp<br>
<br>
Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprScalar.cpp?rev=172047&r1=172046&r2=172047&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprScalar.cpp?rev=172047&r1=172046&r2=172047&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/CodeGen/CGExprScalar.cpp (original)<br>
+++ cfe/trunk/lib/CodeGen/CGExprScalar.cpp Thu Jan 10 03:11:33 2013<br>
@@ -2368,8 +2368,12 @@<br>
 }<br>
<br>
 Value *ScalarExprEmitter::GetWidthMinusOneValue(Value* LHS,Value* RHS) {<br>
-  unsigned Width = cast<llvm::IntegerType>(LHS->getType())->getBitWidth();<br>
-  return llvm::ConstantInt::get(RHS->getType(), Width - 1);<br>
+  llvm::IntegerType *Ty;<br>
+  if (llvm::VectorType *VT = dyn_cast<llvm::VectorType>(LHS->getType()))<br>
+    Ty = cast<llvm::IntegerType>(VT->getElementType());<br>
+  else<br>
+    Ty = cast<llvm::IntegerType>(LHS->getType());<br>
+  return llvm::ConstantInt::get(RHS->getType(), Ty->getBitWidth() - 1);<br>
 }<br>
<br>
 Value *ScalarExprEmitter::EmitShl(const BinOpInfo &Ops) {<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" class="cremed">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>