<div dir="ltr"><div class="gmail_default" style>On Thu, Jan 10, 2013 at 6:42 PM, Richard Trieu <span dir="ltr"><<a href="mailto:rtrieu@google.com" target="_blank" class="cremed">rtrieu@google.com</a>></span> wrote:<br>
</div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="im"><div>On Thu, Jan 10, 2013 at 6:35 PM, Sean Silva <span dir="ltr"><<a href="mailto:silvas@purdue.edu" target="_blank" class="cremed">silvas@purdue.edu</a>></span> wrote:<br>
</div></div><div class="gmail_extra">
<div class="gmail_quote"><div class="im"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Could you please attach an example of the output? It's hard to comment<br>
on the format just by looking through the narrow lens of the FileCheck<br>
assertions.<br>
<br>
-- Sean Silva</blockquote><div> </div></div><div>I can certainly provide an example.</div><div><br></div><div>Code:</div><div><div>int main(int argc, char** argv) {</div><div> int x = 5;</div><div> int y = 2;</div>
<div> return (x * y);</div><div>}</div><div><br></div><div>Old -ast-dump:</div><div><div>(TranslationUnitDecl 0x5341640 <<invalid sloc>></div><div> (TypedefDecl 0x5341b80 <<invalid sloc>> __int128_t '__int128')</div>
<div> (TypedefDecl 0x5341be0 <<invalid sloc>> __uint128_t 'unsigned __int128')</div><div> (TypedefDecl 0x5341fa0 <<invalid sloc>> __builtin_va_list '__va_list_tag [1]')</div><div>
(FunctionDecl 0x53421a0 <simple.cc:1:1, line:5:1> main 'int (int, char **)'</div><div> (ParmVarDecl 0x5342000 <line:1:10, col:14> argc 'int')</div><div> (ParmVarDecl 0x53420d0 <col:20, col:27> argv 'char **')</div>
<div> (CompoundStmt 0x536e8a0 <col:33, line:5:1></div><div> (DeclStmt 0x53422d8 <line:2:3, col:12></div><div> (VarDecl 0x5342260 <col:3, col:11> x 'int'</div><div> (IntegerLiteral 0x53422b8 <col:11> 'int' 5)))</div>
<div> (DeclStmt 0x536e7a0 <line:3:3, col:12></div><div> (VarDecl 0x5342300 <col:3, col:11> y 'int'</div><div> (IntegerLiteral 0x536e780 <col:11> 'int' 2)))</div><div>
(ReturnStmt 0x536e880 <line:4:3, col:16></div><div> (ParenExpr 0x536e860 <col:10, col:16> 'int'</div><div> (BinaryOperator 0x536e838 <col:11, col:15> 'int' '*'</div>
<div> (ImplicitCastExpr 0x536e808 <col:11> 'int' <LValueToRValue></div><div> (DeclRefExpr 0x536e7b8 <col:11> 'int' lvalue Var 0x5342260 'x' 'int'))</div>
<div> (ImplicitCastExpr 0x536e820 <col:15> 'int' <LValueToRValue></div><div> (DeclRefExpr 0x536e7e0 <col:15> 'int' lvalue Var 0x5342300 'y' 'int'))))))))</div>
<div><br></div><div>New -ast-dump:</div><div><div>(TranslationUnitDecl 0x6784640 <<invalid sloc>></div><div>|-(TypedefDecl 0x6784b80 <<invalid sloc>> __int128_t '__int128')</div>
<div>|-(TypedefDecl 0x6784be0 <<invalid sloc>> __uint128_t 'unsigned __int128')</div><div>|-(TypedefDecl 0x6784fa0 <<invalid sloc>> __builtin_va_list '__va_list_tag [1]')</div><div>
\-(FunctionDecl 0x67851a0 <simple.cc:1:1, line:5:1> main 'int (int, char **)'</div></div></div></div></div></div></div></blockquote><div><br></div><div style>So, hopefully no one actually immolates me for asking to repaint this bikeshed, but I'd mildly prefer a ` (back-tick) to \ for the last one....</div>
<div style><br></div><div style><dons asbestos></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<div><div><div><div> |-(ParmVarDecl 0x6785000 <line:1:10, col:14> argc 'int')</div><div> |-(ParmVarDecl 0x67850d0 <col:20, col:27> argv 'char **')</div>
<div> \-(CompoundStmt 0x67b18a0 <col:33, line:5:1></div><div> |-(DeclStmt 0x67852d8 <line:2:3, col:12></div><div> | \-(VarDecl 0x6785260 <col:3, col:11> x 'int'</div><div> | \-(IntegerLiteral 0x67852b8 <col:11> 'int' 5)))</div>
<div> |-(DeclStmt 0x67b17a0 <line:3:3, col:12></div><div> | \-(VarDecl 0x6785300 <col:3, col:11> y 'int'</div><div> | \-(IntegerLiteral 0x67b1780 <col:11> 'int' 2)))</div><div>
\-(ReturnStmt 0x67b1880 <line:4:3, col:16></div><div> \-(ParenExpr 0x67b1860 <col:10, col:16> 'int'</div><div> \-(BinaryOperator 0x67b1838 <col:11, col:15> 'int' '*'</div>
<div> |-(ImplicitCastExpr 0x67b1808 <col:11> 'int' <LValueToRValue></div><div> | \-(DeclRefExpr 0x67b17b8 <col:11> 'int' lvalue Var 0x6785260 'x' 'int'))</div>
<div> \-(ImplicitCastExpr 0x67b1820 <col:15> 'int' <LValueToRValue></div><div> \-(DeclRefExpr 0x67b17e0 <col:15> 'int' lvalue Var 0x6785300 'y' 'int'))))))))</div>
<div><br></div><div><br></div></div></div></div></div></div></div>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" class="cremed">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div></div>