<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 12 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-GB link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Ideally yes, but it's a bit tricky in that the portion of OpenCL implemented OSS clang doesn't support enough OpenCL builttin types to specify vectors in the source. I did have a go at writing a test in standard OpenCL but the compiler choked on it; I'll have a look to see if I can generate vectors from some hack constructs.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Regards,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Dave<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=EN-US style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span lang=EN-US style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Chandler Carruth [mailto:chandlerc@google.com] <br><b>Sent:</b> 10 January 2013 09:32<br><b>To:</b> David Tweed<br><b>Cc:</b> llvm cfe<br><b>Subject:</b> Re: [cfe-commits] r172047 - /cfe/trunk/lib/CodeGen/CGExprScalar.cpp<o:p></o:p></span></p></div><p class=MsoNormal><o:p> </o:p></p><div><div><p class=MsoNormal>On Thu, Jan 10, 2013 at 1:11 AM, David Tweed <<a href="mailto:david.tweed@arm.com" target="_blank">david.tweed@arm.com</a>> wrote:<o:p></o:p></p></div><div><div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm'><p class=MsoNormal>Author: davidtweed<br>Date: Thu Jan 10 03:11:33 2013<br>New Revision: 172047<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=172047&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=172047&view=rev</a><br>Log:<br>Testing with a full OpenCL compiler (based on clang) reveals r71734 missed<br>difference between type widths of a vector and the width of one of its elements<br>in the case of vector shifts. Use correct witdth in the vector case.<o:p></o:p></p></blockquote><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>This still needs a regression test case.<o:p></o:p></p></div><div><p class=MsoNormal> <o:p></o:p></p></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm'><p class=MsoNormal><br>Modified:<br> cfe/trunk/lib/CodeGen/CGExprScalar.cpp<br><br>Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprScalar.cpp?rev=172047&r1=172046&r2=172047&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExprScalar.cpp?rev=172047&r1=172046&r2=172047&view=diff</a><br>==============================================================================<br>--- cfe/trunk/lib/CodeGen/CGExprScalar.cpp (original)<br>+++ cfe/trunk/lib/CodeGen/CGExprScalar.cpp Thu Jan 10 03:11:33 2013<br>@@ -2368,8 +2368,12 @@<br> }<br><br> Value *ScalarExprEmitter::GetWidthMinusOneValue(Value* LHS,Value* RHS) {<br>- unsigned Width = cast<llvm::IntegerType>(LHS->getType())->getBitWidth();<br>- return llvm::ConstantInt::get(RHS->getType(), Width - 1);<br>+ llvm::IntegerType *Ty;<br>+ if (llvm::VectorType *VT = dyn_cast<llvm::VectorType>(LHS->getType()))<br>+ Ty = cast<llvm::IntegerType>(VT->getElementType());<br>+ else<br>+ Ty = cast<llvm::IntegerType>(LHS->getType());<br>+ return llvm::ConstantInt::get(RHS->getType(), Ty->getBitWidth() - 1);<br> }<br><br> Value *ScalarExprEmitter::EmitShl(const BinOpInfo &Ops) {<br><br><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><o:p></o:p></p></blockquote></div><p class=MsoNormal><o:p> </o:p></p></div></div></div></body></html>